Comments (9)
Ah, If I apply it to the repository I forked, it would be jeonbyeongmin/ChatGPT-CodeReview@dev
, right?
I tested it on jeonbyeongmin/ChatGPT-CodeReview@dev
and confirmed that it works properly!
I will resolve this issue and submit a PR! Thank you for explaining it kindly!
from chatgpt-codereview.
@jeonbyeongmin Yes. This a good idea. Considering removed files are not Being used anymore, and review the removed/renamed files is no help on the code, and it's good for reducing the user's token cost
Let's have excluding renamed/removed files by default, if there is any request for reviewing the renamed/removed files in the future, we can consider to add process env to support this configuration then
from chatgpt-codereview.
@anc95 Great! Can I modify the code myself? I wonder how I can run the test of this app.
from chatgpt-codereview.
@jeonbyeongmin Appreciated
Bad new is the it's not easy to test. There are two ways
-
Using GitHub app, the code base is based on probot, you can search and find out how to test with probot.you need to create a GitHub app and get properly configured, then setup all the local env, and install the app for one of your repo, and then trigger the event.
It's really complicated ha -
The second way is using the GitHub actions, you can setup a GitHub action using the action based on your working branch, then trigger action for test.
I am not sure if there is a unit test way to mock data and test.
Sorry that I can't reach my Mac now, so I just typed in an phone, it's not easier to express things clearly to you.
You can try the above two ways, any questions please kindly let me know. Thanks.
from chatgpt-codereview.
@anc95
I understand, but I would like to know more about the second way -- github actions
How can i trigger an unpublished action?
from chatgpt-codereview.
@jeonbyeongmin i am guessing don't need to punish an action
In my case, I am using
anc95/ChatGPT-CodeReview@dev
To test. It can be found and triggered
You can try to replace the repo owner and branch to yours to test
from chatgpt-codereview.
I have run numerous tests, and I have some bad news.
The modified code is not complete.
- "Renamed" is not excluded in any case.
- Only when the pull_request type is "synchronize" (i.e., when commits are added after the PR is opened) are removed files excluded. They are not excluded in the "opened" state.
Do you know how Octokit works? I'm not sure why it's not properly excluding files.
from chatgpt-codereview.
@jeonbyeongmin Sorry for being so late to reply you
I searched the document. there is no clear introduction for files
, here is the document for compare two commits. it says
The API response includes details about the files that were changed between the two commits. This includes the status of the change (if a file was added, removed, modified, or renamed), and details of the change itself. For example, files with a renamed status have a previous_filename field showing the previous filename of the file, and files with a modified status have a patch field showing the changes made to the file.
I am not sure too. but if we can exclude removed files in both open/sync event and exclude renamed files in sync event, it's already is a good improvement
from chatgpt-codereview.
@anc95
Great! However, it seems like more testing is needed. I'll go ahead and submit a PR for now. :)
from chatgpt-codereview.
Related Issues (20)
- using docker error HOT 1
- Can I set OPENAI_API_ENDPOINT in Github App version? HOT 1
- can we exclude auto generated files for code review? HOT 2
- Resource not accessible by integration HOT 2
- npm start doesn't work on v1.0.10 HOT 1
- How can I build this repository? HOT 3
- Misleading logs encountered HOT 2
- deploy on aws lambda HOT 4
- Review comments not given for all changed files HOT 3
- Invalid event payload in draft PR HOT 1
- 有没有手机版本的,楼主怎么下载呢 HOT 1
- How to code review with push instead of pull HOT 2
- It looks like you need to update your Node.js version. HOT 1
- max_token & API key HOT 2
- Discrepancy in action/index.cjs After Running npm run build HOT 2
- Bot is not adding comment in the PR HOT 3
- Privacy Policy HOT 2
- pr没有自动生成review信息 HOT 1
- how about openai lib instead of chatgpt api (npm) ? HOT 1
- Should close old comments after new commits HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from chatgpt-codereview.