Giter Site home page Giter Site logo

Comments (5)

saltandvinegarcrisps avatar saltandvinegarcrisps commented on May 19, 2024

What would you suggest?

When a user selects clean urls the installer copies the htaccess.txt contents to the .htaccess file with the rewrite base if anchor is installed in a subfolder.

from anchor-cms.

JCB-K avatar JCB-K commented on May 19, 2024

Not sure if this is possible, but maybe use FILE-APPEND, so it just adds it to the existing file? I've done this locally, and it manages to write the htaccess in a clean manner, but the installer still gets stuck. I'll let you know about any progress.

from anchor-cms.

saltandvinegarcrisps avatar saltandvinegarcrisps commented on May 19, 2024

I think the best option is to leave the existing htaccess file and the user will have to manually update it to enable clean urls. We cant append and assume its safe to do so.

from anchor-cms.

JCB-K avatar JCB-K commented on May 19, 2024

Read a bit up on it, and the general consensus seems to be that web apps should never edit the .htaccess for exactly that reason. The thing is, by not automating it you're adding another step to the install process. But potentially breaking someone's server setup is not worth eliminating that step.

Maybe let it only write the .htaccess when it doesn't exist yet (as in the dev branch right now), and otherwise give a warning along the lines of:

"It seems like you've already got a htaccess file. Paste this text at the end of your file to setup clean url's."

from anchor-cms.

saltandvinegarcrisps avatar saltandvinegarcrisps commented on May 19, 2024

I agree. Updated in dev branch.

from anchor-cms.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.