Fix lint warnings and make it compatible with latest ADT

[andlyticsproject]

Fix lint warnings and make it compatible with latest ADT

[AndyScherzinger]

I've seen that you forked our master and started fixing this (at least lint), would you mind sending us a pull request afterwards? Thanks :-)

[nelenkov]

The once I did a quite 'safe', so I'll send those first. Others might need some testing. Annotation related stuff depends on ADT version (introduced in 18 or 19, IIRC) though, so we need to make sure it will work for most people (at least). What ADT version(s) are you guys using? Everyone using Eclipse?

[fda77]

Yep, Eclipse (but the git plugin is horrible!)

[AndyScherzinger]

Also Eclipse + ADT 19

[AndyScherzinger]

Did anyone checkout ADT 20 yet?

[fda77]

windows 7 + eclipse 4.2 + api 16 + adt 20 runs

[AndyScherzinger]

can this be closed? We use ADT20 now and the lint warnings shouldn't be tracked by an issue, since we will never get this issue closed then imho.

voting for close +1

[nelenkov]

You should never have warnings :) Most of the things have been fixed, so close it if you want. People should just remember to check/fix warnings once in a while.

[AndyScherzinger]

Well, Lint tells me: 14 errors (!) and 273 warnings... mostly thanks to ActionBarSherlock though...

[nelenkov]

ABS generates a lot of those, you can ignore them, it's not an app after all. Some of the things are false positives, so set it to ignore the ABS project and check then, adding the wrong ones to lint.xml (this should probably be added to VC).

[AndyScherzinger]

@nelenkov what's your opinion on closing this issue? Project is ADT20 compatible and we merged your lint fixes a while ago. As for the ignore lint.xml I haven't found a "tutorial" on how to do this :( Any link is highly appreciated so we can get rid of the ABS warnings and just see the Andlytics ones).

[nelenkov]

If you click 'ignore in this project' in the lint errors view, lint.xml will be generated automatically in the root of the project. Ignoring other errors/warnings adds rules to it. As for closing the issue, sure go ahead.

[AndyScherzinger]

Thanks for the info. Will close it after I added the lint.xml

[nelenkov]

I've added lint.xml in the dev branch, but there are still some warnings about duplicated and missing icons. Some of them are unused (icon_refresh, spinner_*). Should we remove them, or does anyone have plans for them :)

[AndyScherzinger]

I vote for removal then :-)

[nelenkov]

Remaining warnings should be fixed or explicitly ignored before next release, but it's high time this got closed as well.