Giter Site home page Giter Site logo

Comments (5)

splitbrain avatar splitbrain commented on June 8, 2024 1

Perfectly fine solution for my use case. Feel free to close the issue.

from simplelightbox.

Mtillmann avatar Mtillmann commented on June 8, 2024

Hi, could you provide a small example of the issue and check if the rel-option might fix your issue? Thanks

from simplelightbox.

splitbrain avatar splitbrain commented on June 8, 2024

The rel option isn't really relevant here, since I do want all the images to show up in the same gallery.

Here's a minimal example:

https://jsfiddle.net/frv10bps/1/

The first image can be clicked to open the lightbox. The second image will not have an event handler attached. Set uniqueImages to false and both images will open the lightbox, but of course now the image is also twice in the gallery.

from simplelightbox.

Mtillmann avatar Mtillmann commented on June 8, 2024

Thanks, this looks like it should't happen. I'll look into it later if find the time!

from simplelightbox.

Mtillmann avatar Mtillmann commented on June 8, 2024

The uniqueImage option is not properly implemented. It will filter the links that open the images instead of the images. This explains your issue.

I'm not exactly sure what the idea behind the option is but I guess it's meant to deduplicate images in the opened lightbox. I don't know how that could without breaking the expected order of images when an image is in the set twice or more times.

For now you should not use that option unless you want opener links with duplicate href-attributes to be omitted

from simplelightbox.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.