BCC and CC in Razor view when ViewBag.Bcc or ViewBag.CC is empty

[andrewdavey]

BCC and CC in Razor view when ViewBag.Bcc or ViewBag.CC is empty

[DWalkit]

In case anyone else runs into this, an easy workaround (at least it works in MVC4) is to move the Bcc or CC to the bottom of your header, with a Razor @if, like so:

To: @ViewBag.To
From: @ViewBag.From
Subject: @ViewBag.Subject
Content-Type: text/html @if (@ViewBag.CC != null) {
CC: @ViewBag.CC
}

If I put the CC part on its own line it wouldn't always work. And I actually included the 'CC:' in the ViewBag.CC but added it above as I'd imagine it'd work that way, too! Obviously, in your controller code, you'll want to set email.CC = null if you have no addresses to add! And I have it all on one line, GitHub is formatting it for me! It may not work on more than one line!

[andrewdavey]

Please do fork the code and have a go at fixing this. I'd be very happy to accept a pull request. Thanks :)

[jfrank14]

Why does it have to be at the end of the file? Wouldn't it work the same if it came right after the To: line?

[petersondrew]

I took a slightly different approach since I use strongly-typed emails. I use a shared layout for my email templates with the following:

@model Models.EmailBase
To: @Model.To
From: [email protected]
Subject: @Model.Subject
Content-Type: text/html; charset=utf-8
@RenderSection("bcc", required: false)

Then in my email view:

@model Models.SomeEmaliWithBcc
@section bcc {BCC: @Model.Bcc}

That could also easily be extended to handle cases where Bcc is null or empty:

@model Models.SomeEmaliWithBcc
@if (!String.IsNullOrEmpty(Model.Bcc))
{
    @section bcc {BCC: @Model.Bcc}
}

[andrewdavey]

I recommend taking a look here:

postal/src/Postal/EmailParser.cs

Line 55 in 409617d

void AssignCommonHeaders(MailMessage message, Email email)

It should be possible to add some extra guards for empty email addresses.

[jfrank14]

Thanks. I will check it out.

On 8/26/2014 9:19 AM, Andrew Davey wrote:

I recommend taking a look here:

postal/src/Postal/EmailParser.cs

Line 55 in 409617d

void AssignCommonHeaders(MailMessage message, Email email)

It should be possible to add some extra guards for empty email addresses.

---

Reply to this email directly or view it on GitHub #38 (comment).

[petrosmm]

@DWalkit wrote correctly in his analysis of the problem. However, does any such remedy exist for the 'Reply-To', it has a much different behaviour.