Comments (10)
Makes sense 👍 Although I would prefer just using keydown instead of bringing in another library.
from sound-redux.
OK, I already have a pr by adding arrows events using keydown, also i added notifications to deezer style, in case you're in another tab.
from sound-redux.
Cool, but I'd prefer to have the notifications be a setting that users opt into. It'd be annoying if I suddenly started getting notifications without an explanation. What do you think?
from sound-redux.
of course, the first time load you page, ask if you want to receive notifications
from sound-redux.
Google will manage notifications
from sound-redux.
Sounds good. I just remember turning on notifications for a website one time, not knowing exactly what would happen (new news articles) and got super annoyed. Is it possible to describe exactly what the notifications will do when asking for permission?
from sound-redux.
I think that it's not possible,When you run Notification.requestPermission, it only shows a popup saying: "https://soundredux.io" wants to show notifications -> Block or Allow.
requestPermission
from sound-redux.
What a few sites do, when they want to enable notifications, is have an "Enable notifications" checkbox/button underneath a paragraph or two explaining exactly what and why, in some kind of settings area.
It gives them an easy way to turn them on and off, and lets them know what it'll do.
from sound-redux.
Also, for those who don't know - shift + ← / shift + → will go back and forth between songs, just like SoundCloud!
from sound-redux.
@andrewngu Should this be closed now?
from sound-redux.
Related Issues (20)
- [Bug] Not being able to fetch more songs HOT 2
- [Improvements] Fadein images
- Uncaught ReferenceError: webpackJsonp is not defined at main.js:1
- How to set sound-redux folder in GoPath HOT 1
- ERR_EMPTY_RESPONSE HOT 5
- Create telegram group and include it in .md file for discussion.
- getPlaylist initialized in UserSelectors.js:7 and SongSelectors.js:27 HOT 1
- Player of sound-redux not work in localhost (http://localhost:8080) HOT 1
- Smoother stickyOnScroll...?
- Uncaught (in promise) DOMException: Failed to load because no supported source was found. HOT 1
- Songs won't load HOT 2
- Songs won't load
- Doing a clone in Elm HOT 1
- error when i try to sign into soundcloud HOT 1
- Music List is not loading on Production HOT 3
- delete me
- using 'Component' instead of 'PureComponent'
- npm run start is not working HOT 3
- Using deprecated lifecycle methods HOT 1
- npm install and npm run start is not working HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sound-redux.