Comments (4)
<superjoe> this is how replaygain should be solved:
<superjoe> a media player has a database of songs. replaygain information is stored in this database as well.
<superjoe> when a file is added to the library, the media player uses the same mechanism as it uses to generate sound to do replaygain analyzation
<superjoe> replaygain information is computed per-track as well as per-album
<superjoe> when a song starts playing, if the track before or the track after are from the same album, use album replaygain mode, else use track replaygain mode.
<superjoe> if replaygain tags are missing when playback is supposed to start, do the scan before playback starts. this glitch won't happen the 2nd time you try to start playback.
Let's find a media player that solves replay gain this way. If one doesn't exist, we might have to make it ourselves.
from groovebasin.
What if I queue up Through My Words by Dream Theater, which is very quiet, and get half way through the song. Then I queue up the following track, Fatal Tragedy, which is much louder. There's a seamless transition between the two tracks in the album, so any slight variation in volume control will be noticeable. Your algorithm says that the replaygain mode will switch from track to album at this transition, which will cause a volume jump.
How about: always use album mode.
Then the problem is recalculating the album average when the set of songs in the album changes. We can recreate the problem in the previous paragraph by uploading and queuing Fatal Tragedy halfway through playing Through My Words. I argue that this is a more obscure failure case, and a better approach to the problem.
from groovebasin.
Excellent point. I agree with your conclusion.
from groovebasin.
This is now working in master 👯
from groovebasin.
Related Issues (20)
- Chromecast as output HOT 4
- Possible to redirect from apache to groovebasin? HOT 9
- Where are the logs for Groove Basin? HOT 1
- 100% CPU utilization on first run in Firefox and Chrome (HEAD) HOT 1
- Most of my albums are "Various Artists" but should not be HOT 6
- Release 1.6 and the protocol spec HOT 2
- Diffing on subscription updates is fundamentally problematic
- Working MPD Android client suggestions? HOT 1
- Domain name has expired HOT 1
- ../src/player.h:6:10: fatal error: grooveplayer/player.h: No such file or directory
- `npm start` fails on Ubuntu 17.04 in docker
- screenshots links are broken
- Update Nix package
- It would be awesome if your project got some love again. HOT 10
- a feature to replace song(s) with different files
- screenshots of the ui
- Help with getting this awesome player installed... HOT 1
- Feature request - Song voting
- Something seems to be missing from the zig build instructions HOT 1
- Segfault in playlist.c in zig-pkg branch
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from groovebasin.