Giter Site home page Giter Site logo

Comments (7)

thejoshwolfe avatar thejoshwolfe commented on September 22, 2024

another library option:
https://github.com/wellawaretech/node-zipstream

from groovebasin.

thejoshwolfe avatar thejoshwolfe commented on September 22, 2024

It looks like from here:
http://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html#sec4.4
the Content-Length http header field is required, which will be tricky with a streaming zip file. Perhaps there is a way to determine without error how big the zip will be. Perhaps there's a protocol besides http that will work that doesn't require we know the file size prior to sending.

EDIT: nevermind. It looks like the http library will automatically use chunked encoding if the content length is omitted.

from groovebasin.

thejoshwolfe avatar thejoshwolfe commented on September 22, 2024

unicode filenames are broken according to here:
https://github.com/wellawaretech/node-zipstream/issues/4

from groovebasin.

andrewrk avatar andrewrk commented on September 22, 2024

It should be pretty easy to expand the "Download" context menu option for multi-select to download a zip.

from groovebasin.

thejoshwolfe avatar thejoshwolfe commented on September 22, 2024

another thing that's broken:

  • canceling a download doesn't abort the operation server-side (try downloading /library/)

what api are we going to use for multi-select downloading? The url length limit cautions me away from encoding everything in a download url. We should be able to support downloading selections of thousands of files.

from groovebasin.

andrewrk avatar andrewrk commented on September 22, 2024

it doesn't have to be a GET. a POST is fine.

from groovebasin.

andrewrk avatar andrewrk commented on September 22, 2024

I theoretically fixed cancelling a download aborting the operation server side. Untested.

Only thing left to do now is multiselect downloading.

from groovebasin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.