Does a memoized function return a new value if called with different arguments?

[callumlocke]

Does a memoized function return a new value if called with different arguments?

[andreypopp]

This is very simple implementation which doesn't allow memorisation for function with arguments. Only zero argument functions are allowed.

[callumlocke]

OK. Would you be interested in adding this feature? Or do you think it would be better as a separate module?

@memoizePerArgs or something... not sure what the best terminology would be

[andreypopp]

Yeah, I'm open for adding this feature to this module. But under a different API.

[callumlocke]

do you mean offering two decorators, with separate named exports, like this?

import {memoize, memoizeArgs} from 'memoize-decorator';

[andreypopp]

I think we should use WeakMap where available for a memoization table. Memoization key should be made configurable and should be the explicit choice, e.g. pass key function to decorator when creating. We could provide some sensible default though, like calling toJSON on an arg tuple.

[andreypopp]

Yeah, memoizeByArgs or something like that. I'm not a native speaker but memoizeArg sounds like you want to memoize args themselves.