Giter Site home page Giter Site logo

Comments (7)

droid-girl avatar droid-girl commented on June 11, 2024

Hi @yuriikonovalov, could you share your Transformer export settings, frame rate or any other parameters you set in Transformer?

from media.

yuriikonovalov avatar yuriikonovalov commented on June 11, 2024

Hi @droid-girl, here are MediaItem and Transformer builders. Just in case it matters, the PNG frame is created via ffmpeg library from a webm video.

Media items:

    val backgroundMediaItem = MediaItem.Builder()
        .setUri(backgroundUri)
        .setMimeType(MimeTypes.IMAGE_PNG)
        .build()

    val backgroundEditedMediaItem = EditedMediaItem.Builder(backgroundMediaItem)
        .setDurationUs(6_000_000)
        .setFrameRate(30)
        .setEffects(
            Effects(
                listOf(),
                listOf(Presentation.createForWidthAndHeight(1080, 1920, Presentation.LAYOUT_SCALE_TO_FIT_WITH_CROP))
            )
        )
        .build()

    val frameMediaItem = MediaItem.Builder()
        .setUri(frameUri)
        .setMimeType(MimeTypes.IMAGE_PNG)
        .build()

    val frameEditedMediaItem = EditedMediaItem.Builder(frameMediaItem)
        .setDurationUs(6_000_000)
        .setFrameRate(30)
        .setEffects(
            Effects(
                listOf(),
                listOf(Presentation.createForWidthAndHeight(1080, 1920, Presentation.LAYOUT_SCALE_TO_FIT_WITH_CROP))
            )
        )
        .build()

Video composition:

    val backgroundSequence = EditedMediaItemSequence(backgroundEditedMediaItem)
    val frameSequence = EditedMediaItemSequence(frameEditedMediaItem)

    val composition = Composition.Builder(frameSequence, backgroundSequence)
        .setEffects(
            Effects(
                listOf(),
                listOf(
                    Presentation.createForWidthAndHeight(1080, 1920, Presentation.LAYOUT_SCALE_TO_FIT_WITH_CROP),
                    FrameDropEffect.createDefaultFrameDropEffect(30f),
                )
            )
        )
        .build()

Transfromer settings:

    val transformer = Transformer.Builder(context)
        .setVideoMimeType(MimeTypes.VIDEO_H264)
        .setAudioMimeType(MimeTypes.AUDIO_AAC)
        .setEncoderFactory(DefaultEncoderFactory.Builder(context.applicationContext).build())
        .addListener(transformerListener)
        .build()

    transformer.start(composition, outputFilePath)

from media.

yuriikonovalov avatar yuriikonovalov commented on June 11, 2024

Here is also a video created from same background and frame PNG images but using ffmpeg.

ffmpeg.mp4

from media.

droid-girl avatar droid-girl commented on June 11, 2024

Thank you for sharing this information. There might be several reasons for this behaviour.
@tof-tof: I wonder if downscaling is producing this artifact and a downscaling algorithm would solve this problem? or is there another reason?

from media.

tof-tof avatar tof-tof commented on June 11, 2024

Hmmm not completely sure. sounds a bit like #1050 which is being solved by upcoming work, we'll see if that solves this as well

from media.

yuriikonovalov avatar yuriikonovalov commented on June 11, 2024

@tof-tof I guess #1050 fixes the color problem but not the quality problem. Maybe the reason for that is the bitrate of the output video? I compared the original video (size - 1080:1920, so scaling should not be the case) with the output video. The bitrate of the original video is 13815kbps. The bitrate of the output video is 8582kbps.

The original video and the output video.

from media.

droid-girl avatar droid-girl commented on June 11, 2024

As an experiment, you can try setting bitrate value as described here.
Assigning this issue to @ychaparov for his input

from media.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.