Weird mod loading issue

[anegostudios]

Weird mod loading issue

[copygirl]

Is this only an issue on the server or does the mod also not load when you're playing singleplayer?

[milochristiansen]

It loads fine in single player. I'm guessing it has something to do with the working directory not being the binary directory, but I'm not familiar enough with .NET to tell for sure.

I don't really want to experiment too much on the server, since I don't want to screw anything up.

EDIT: I made a similar setup in single player on Windows (setting the working directory to something other than the game directory), and was not able to duplicate the issue.

[tyronx]

https://stackoverflow.com/questions/14490247/csc-error-cs0006-metadata-file-could-not-be-found-building-a-net-3-5-applicatio mentions C# 7 language features as issue - which would make sense because mono 4.6 supports only up to C# 6.

Assuming to be this issue. Please reopen if that is not the case.

[milochristiansen]

I added <LangVersion>6</LangVersion> to the .csproj file and compiled, and it worked fine, so that shouldn't be the issue here. (To make sure that key was working correctly I set it to various other values to see what errors I got, for example it won't compile with iso-1.)

(I can't reopen the issue since I didn't close it...)

[tyronx]

Send me source files please

[milochristiansen]

BrickTransitionBehavior.zip

[milochristiansen]

The whole mod is over here

[tyronx]

Did you run this from within the IDE or from console?

[milochristiansen]

When test compiling I used the console (dotnet build), when running on the server I used the (whole mod) zip linked above with the command in the first post (the zip was in /home/vintage/data/gamedata/Mods).

[milochristiansen]

Just to be 100% clear, when I compiled the .cs file and tried to load the mod with a dll instead of the .cs it worked. I would prefer not to have to do this, but for now that will be an acceptable workaround.

Whatever the issue is, it is limited to loading raw .cs files, probably only in mono.

[tyronx]

Thanks for the feedback. Another theory is that the currently used CSharpCodeProvider seemingly (https://stackoverflow.com/a/31641533/1873041) only compiles c# code until C# 5.0 and thus causes issues when trying to reference C# 6.0 libs?

[tyronx]

Hm but then again, my source mod works just fine on debian / mono 5.4.1.7
What if you update to mono 5?

[milochristiansen]

Sorry, I read this yesterday, but forgot to reply :(

The system in question isn't mine, so I don't want to mess with it any more than I have to.

[tyronx]

@copygirl does your updates on the modloader also load stuff in order of dependency? This should fix this problem then.

[copygirl]

I don't think I do ordering, but it's something that could be done.

[tyronx]

@milochristiansen does this issue still happen with 1.5.3?

[tyronx]

copygirls refactorings should fix this, so assuming this is fixed. Please reopen otherwise

[milochristiansen]

This is not fixed.

3:22:20 PM [Server Warning]: Error discovering files for 'BrickInTheWall.zip': 'BrickTransitionBehavior.cs' found at invalid path 'BrickTransitionBehavior.cs'. All .cs files should be in a subfolder 'src' of the mod folder / archive. This will be an ERROR in the future!
3:22:20 PM [Server Warning]: Mod 'BrickInTheWall.zip' (brickinthewall): Error parsing version string '1.2' at index 3: Expected PATCH version, found end of string (best guess: 1.2.0)
3:22:20 PM [Server Error]: Compiler errors during compiling mod 'BrickInTheWall.zip' (brickinthewall):
3:22:20 PM [Server Error]: [:0] [CS0006] Metadata file `VintagestoryAPI.dll' could not be found
3:22:20 PM [Server Error]: [:0] [CS0006] Metadata file `Lib/Newtonsoft.Json.dll' could not be found
3:22:20 PM [Server Error]: [:0] [CS0006] Metadata file `Lib/protobuf-net.dll' could not be found
3:22:20 PM [Server Error]: [:0] [CS0006] Metadata file `Lib/Tavis.JsonPatch.dll' could not be found
3:22:20 PM [Server Error]: Error loading mod 'BrickInTheWall.zip' (brickinthewall):
3:22:20 PM [Server Error]: System.Exception: Error(s) compiling mod 'BrickInTheWall.zip' (brickinthewall) from source files
3:22:20 PM [Server Error]: at _gpHtMiskGLjqPGZxwTher6nxdoG._KR6aEbe5eiNuqwaa2EH6wfBLvSd (_QtTCbWTgLzQ0L5pnJ4SA0p0S4nW , System.Collections.Generic.IEnumerable`1[T] ) [0x00141] in <00cbb88cfc944a46ba4ac8d0bbad9be6>:0
3:22:20 PM [Server Error]: at _QtTCbWTgLzQ0L5pnJ4SA0p0S4nW._QsEdKSeIRDVeKF6yvYWCoIe6ZXp (Vintagestory.API.Common.ILogger , _gpHtMiskGLjqPGZxwTher6nxdoG , _qTMXzQjTmZCapFMQ0QaS7GReooq ) [0x000d3] in <00cbb88cfc944a46ba4ac8d0bbad9be6>:0

There are a few other warnings in there, but the core error is the same.

[copygirl]

What happens if you change to the directory the VintagestoryServer.exe is in before you run it? That would confirm that the working directory is the issue.

[milochristiansen]

Well, since the server exhibiting this issue is being run under the monitor, and it would be a pain in the rear to run it manually, I decided to see what would happen if I ran the VS server with the current working directory not set to the same directory as the EXE on my PC. The result? I can reproduce the issue on my system now.

It seems this is 100% reliable. Run VS with the working directory set to anything other than the binary directory, and it fails to load mods that are not compiled.

BTW: This issue is still marked closed, and I cannot change that.

[copygirl]

Should be fixed for 1.5.4 now. Only waiting for Tyron to accept my merge request.

[tyronx]

I'll assume this is fixed now.