1.5.2.1 Weird textures (linux, singleplayer)

[anegostudios]

1.5.2.1 Weird textures (linux, singleplayer)

[copygirl]

What's your linux distribution, graphics card and drivers?

[tyronx]

I have a feeling it's related to the pngcrush I executed over all the pngs to get rid of the 'Incorrect sRGB profile' error

[copygirl]

@tyronx Does that explain the crafting table leaves, too?
@zkol So earlier versions don't have this bug?

To find out whether the PNG files are what's causing this, one could copy them over from the new version over the old one or the other way around.

[tyronx]

I dunno really, but please do test

[tyronx]

Also @copygirl do you also get these issues?

[copygirl]

Game looks fine for me (and I'm quite happy about the libPNG warnings being gone).

[tyronx]

Oh ok, thats good to hear. Maybe you and @zkol could also compare the installed libPng Version?

[copygirl]

I personally doubt it's important. How would this affect the creation of the terrain texture atlas? Either way, here you go:

 copygirl@yuuko  ~  pacman -Qs png
local/lib32-libpng 1.6.34-1
    A collection of routines used to create PNG format graphics files (32-bit)
local/lib32-libpng12 1.2.59-1
    A collection of routines used to create PNG format graphics files
local/libpng 1.6.34-2
    A collection of routines used to create PNG format graphics files
local/libpng12 1.2.59-1
    A collection of routines used to create PNG format graphics files

[zkol]

Linux karg 4.4.0-116-lowlatency #140-Ubuntu SMP PREEMPT Mon Feb 12 22:41:05 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
01:00.0 3D controller: NVIDIA Corporation GM107M [GeForce GTX 960M] (rev a2)
ii  libpng12-0:amd64    1.2.54-1ubuntu1   amd64   PNG library - runtime
ii  libpng12-0:i386     1.2.54-1ubuntu1   i386    PNG library - runtime
ii  libpng12-dev:amd64  1.2.54-1ubuntu1   amd64   PNG library - development

The previous versions did not have this bug, of course.

[zkol]

Updating to 1.5.2.2 did not change the problem.
Additional Info: seems that the messed up textures always change a bit, for every server restart. Here are some examples:







I like the last one very much

[tyronx]

Lol, thats too wicked. Maybe a peek into the texture atlas reveals something. Please send me the output of .debug exptexatlas block. It should generate a png file where the VintageStory.exe resides.

[tyronx]

Also @zkol please try for me one more thing. Copy&Overwrite all textures from 1.5.1.6 into your 1.5.2.2 folder. Then we can identify if the engine is at fault or pngcrush

[zkol]

here comes the atlas

[zkol]

Ok, I'll try to patch the textures. But why not the textures from 1.5.2 - in 1.5.2 there was no texture issue. Maybe this information may help you.

[tyronx]

Oh yea, 1.5.2 is fine too then

[tyronx]

Well I did find some minor brainf*** in my code involving converting an array of pixels into a system.drawing.bitmap and back for no apparent reason, maaaaaybe that fixes something. Also should speed up start up times by 0.5 - 2 seconds \o/

[zkol]

I did the texture patch in between (with 1.5.1.6) and the issue seems to be gone.

[tyronx]

Aw. So it is the pngcrush I guess :/

[tyronx]

Ok, just confirmed to be not the game engines fault. Either mono or pngcrush borks it.

[tyronx]

Reported on the mono bug tracker: mono/mono#7821

[tyronx]

Also reverting to pre-pngcrush files until we know more about it from the mono guys.

[filipnavara]

It was fixed in libgdiplus last year (mono/libgdiplus#47, mono/libgdiplus#77). That library is used by Mono to implement System.Drawing and the related graphics manipulation. New enough libgdiplus+Mono should be enough to fix the issue. It is possible to avoid triggering the issue by running pngcrush with different parameters, but probably not worth the effort.

[tyronx]

Thank you! @filipnavara

[zkol]

Tested 1.5.2.4 successfully (no such texture issue). Thanks a lot!

[tyronx]

Yea but @copygirl has her error log spam back :<
Probably need to fiddle with pngcrush options to make it print no errors. That can go into a new issue though.

[filipnavara]

You can strip just the color profiles by running pngcrush -rem gAMA -rem cHRM -rem iCCP -rem sRGB -noreduce -ow <files>.

[tyronx]

Oh okay, thanks a lot @filipnavara! I'll try that out.