jsp files can have duplicate hyperlinks

[angelozerr]

jsp files can have duplicate hyperlinks

[angelozerr]

I have no this problem with my sample project.

Are you sure that you have not several time this CSS ID?

@gamerson could you share a simple project which causes your problem please?

[gamerson]

ok after looking at this again it is because I added a new web resource provider extension point that added all the css and scss files in the current project. But it seems that is already been added by the Preferences provider so I don't need to add my own, not even sure why I added it in the first place. Closing sorry for the noise.

[angelozerr]

Closing sorry for the noise.

No problem @gamerson

I tell me if we should or not add a filter for that :

• pros : you have not your problem
• cons : you don't see that your new provider search too the sam ething than preferences provider.

[gamerson]

actually a filter would be nice for webresources collector to filter duplicate names maybe? Look at what happens because in Liferay IDE we are adding all of the bootstrap sass files (lots of duplicate names) because of how Eclipse css model parsers sass files.

http://i.imgur.com/8odPd5n.png

[angelozerr]

I have done that because CSS class name can be declared in several location.

I think there is several case :

• for completion, we should display one CSS class name and merge the whole CSS text coming from the same CSS class name.
• for hyperlink, we should keep the behaviour as today.
• for text hover, we should do the same thing than completion (merge teh same CSS class name).

[gamerson]

Agreed, the only thing for completion is when it displays the hover info on
the right the name might not actually match the correct originating file
(at least from developer's perspective) but I think that is ok consider
they would rather not see the duplicates.

On Mon, Oct 6, 2014 at 9:21 PM, Angelo [email protected] wrote:

I have done that because CSS class name can be declared in several
location.

I think there is several case :

• for completion, we should display one CSS class name and merge the
  whole CSS text coming from the same CSS class name.
• for hyperlink, we should keep the behaviour as today.
• for text hover, we should do the same thing than completion (merge
  teh same CSS class name).

—
Reply to this email directly or view it on GitHub
#18 (comment)
.

Greg Amerson
Liferay Developer Tools
Liferay, Inc. www.liferay.com