Comments (2)
Hi there!
Thanks a lot for your kind words. Happy to hear you're enjoying the book.
The case you're describing should definitely work; there might be a bug somewhere in the code.
Would you be so nice as to include a small snippet of code that reproduces the error you describe? I'm currently out from home without a laptop to work, but as soon as I get back I'll take a look at this.
Best,
รngel
from mechanics.
Hi,
I looked a little more today when time allowed and I was slightly wrong about the square/rectangle issue. The only issue I see is with the way the points of the polygon are listed. In my testing the polygon points were added moving clockwise through the polygon hence the angles always ended up negative which yields a failure as the test case is limited to positive angles. I'm not sure if it is conventional to list the points in counter-clockwise manner or if the algorithm should take that into account by checking the absolute value of the angle sum? I modified the test file slightly to illustrate the case.
class TestPolygon(unittest.TestCase):
vertices = [
Point(0, 0),
Point(30, 0),
Point(0, 30),
]
polygon_1 = Polygon(vertices)
def test_contains_point_polygon_1(self):
point = Point(10, 10)
self.assertTrue(self.polygon_1.contains_point(point))
vertices_2 = [
Point(0, 0),
Point(0, 30),
Point(30, 0),
]
polygon_2 = Polygon(vertices_2)
def test_contains_point_polygon_2(self):
point = Point(10, 10)
self.assertTrue(self.polygon_2.contains_point(point)) <== Fails (FALSE)
The test will fail on polygon_2 which is the same polygon with the points listed in reverse order.
from mechanics.
Related Issues (2)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mechanics.