Remove jQuery UI dependency

[j8]

Remove jQuery UI dependency

[douglasduteil]

Agreed
@ProLoser I'm working on a fork to drop this dependence.

[douglasduteil]

Just saying that I didn't drop the issue
I have a early version here

[douglasduteil]

Update : http://plnkr.co/guRVnr

• Change position parsing
• Add style example
• Observe max and min attributes

[douglasduteil]

K I'm releasing a early version

[j8]

@douglasduteil Extremely great work, can't wait to get handson with the early version. Don't forget the callbacks, especially onRelease, as it will be critical for inline editing application and promises. Also I can give a hand for the mobile version of this, if needed.

[douglasduteil]

K @j8 I wasn't happy about the templating system in this directive. So I made a verbose version of it.
Before :

<ui-slider></ui-slider>

After

<ui-slider class="ui-slider-default">
  <slider-track>
    <slider-thumb ng-model="_"/>
  </slider-track>
</ui-slider>

The thumb is now customizable and the value of each thumb can be binded.
Here is a demo of how it look

[Nate-Wilkins]

@douglasduteil How far along was this? I see the build is currently failing on travis but not sure if that's a setup issue or not.

Will the no-jquery branch eventually be (or merged to) master?

[douglasduteil]

Hi @Nate-Wilkins
I was near a official release but presently I don't have the time to do it... If I remember right the branch I was working on was the pure-angular on the 'scenar' tests

[apitts]

I have been using this branch (no-jqui-here) for a while now....really like the features and lack of jQuery.

[johnparn]

Sounds promising. We should definitely make this the master if it is ready
for release. I haven't had the opportunity to use this branch myself so far.

//John
Den 19 apr 2014 07:18 skrev "Andrew Pitts" [email protected]:

I have been using this branch for a while now....really like the features
and lack of jQuery.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/27#issuecomment-40861194
.

[apitts]

The only issue I have found so far is that it does not seem to handle decimals well. For example, a slider with a range of 0 to 5 (step of 0.02) and starting values of 0.3 and 1.0 doesn't seem to work well. It starts at 0 and 1.0. A chance this could be an error I'm making though.

[apitts]

@douglasduteil @johnparn any further thoughts about making the no-jqui-here branch master? Thanks.

By the way, I'm not certain, but I think the issue with decimal places is being caused by Math.floor.

[Nate-Wilkins]

@douglasduteil no problem I can look through the code test out any remaining bugs. I'll report back when/if I find any. Thanks!

[apitts]

Sharing the below in case it is helpful.

So, I think that the issue that I was having with the decimal places is now resolved. Once I added a step on each ui-slider-thumb that was the same as the step that I had on the ui-slider, I no longer had the issue. What I believe was happening is that the default values for the thumb (i.e. 1 was overriding the value I expected from the ui-slider).

I did however notice a couple of other things. I was getting this issue with values over 100 but only where I had two thumbs and a range (obviously the proposed solution doesn't really apply to this branch or at least I couldn't see how): #20. What I did to fix this (hopefully) is to change _cache.[x] to iAttrs.[x], e.g.:

            _cache.min = (angular.isDefined(iAttrs.min)) ? _cache.min : uiSliderCtrl.min;

to

            _cache.min = (angular.isDefined(iAttrs.min)) ? iAttrs.min : uiSliderCtrl.min;

This change is in a fork I created today...seems OK at the moment but I haven't thoroughly tested it: https://github.com/apitts/ui-slider

Another issue I had was in passing an expression for a step size. If the max value was not a multiple of the step size, the max value displayed would be slightly less than the inputted max value due to rounding I believe caused by these lines:

formattedValue = Math.floor(formattedValue / step) * step;

return Math.floor(value / _cache.step) * _cache.step;

Basically, I was choosing a step value that divided evenly into (max - min) which I think makes sense but these calculations seem to require that it divides evenly into max. For the moment I have fixed this by choosing a step value that divides evenly into max.

@douglasduteil ... very nice slider ... small request (which you can ignore if you don't think it worth it).

The no-jqui slider is not compatible with Angular 1.1.x as it's using one 1.2.x feature which makes this not work on 1.1.x angular.

it's: $isEmpty

Could you consider null/empty check without use of $isEmpty?

https://github.com/angular/angular.js/blob/e37e67eadbd5c8b5342499f8a4f27d644106b3f2/src/ng/directive/select.js#L235

https://github.com/angular-ui/ui-slider/blob/no-jqui-here/src/ui-slider.js#L273
https://github.com/angular-ui/ui-slider/blob/no-jqui-here/src/ui-slider.js#L288
https://github.com/angular-ui/ui-slider/blob/no-jqui-here/src/ui-slider.js#L303
https://github.com/angular-ui/ui-slider/blob/no-jqui-here/src/ui-slider.js#L315

[douglasduteil]

Hi all I made another poke for this. An 'official' update will be made soon enough.

[rzschech]

@douglasduteil you should take a look at apitts improvements made here: https://github.com/apitts/ui-slider

[douglasduteil]

@rzschech @apitts That looks cool.
I'm looking forward to merge some of those changed 👍

[apitts]

Excellent! 👍 Thanks @douglasduteil!

[rzschech]

@douglasduteil I've added support for step="any" similar to:

<input type="number" step="any">

rzschech@8257e85

[PowerKiKi]

@douglasduteil where are we with the no-jquery version ? anything that should be merged here ? or did it become an independent project ? should this issue be closed ?

[douglasduteil]

Hi. Good timing @PowerKiKi I'm actually working on a new version of it :)
my last attempt

[PowerKiKi]

let us know if/when something should be merged here

[PowerKiKi]

Closing as obsolete