Issue to develop / test

[angular-ui]

Issue to develop / test

[ProLoser]

I am trying to figure out how to remove the jquery event code. As for
browsers I have been using the param --browsers=Chrome
On Apr 17, 2013 12:03 PM, "Arnaud BRETON" [email protected] wrote:

Hi,

I've just started to backport my patch related to this issue
angular-ui/angular-ui-OLDREPO#536angular-ui/angular-ui-OLDREPO#536

If I have well understood, angular-ui will progressively move here, for
all directives with no external deps.

I've met some issues to start developping on it:

• No gruntfile (=> no server, watch target)
• No browser specified in Karma conf
• Bower modules not included in the repo (maybe it's wanted?)
• Keypress directive specs are still related to jQuery (in
  createKeyEvent: var keyEvent = jQuery.Event("keydown");)

Am I missing something?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/7
.

[arnaudbreton]

I think these kind of issues are requirements for people to actively develop on this project right?
I think I will start to backport my patch on angular-ui first and do it when ui-utils will be more mature.

Yes I used this param too for Karma, but it's not a big deal to precise a default one, mainly for the future grunt task.

[ProLoser]

I will not be accepting any more patches to AngularUI as there is no point to maintain both projects. Most of the issues you mentioned are fairly easy to bypass, and I don't see a reason why adding more parameters to your karma command is a big deal.

If you want to make changes to the repo nothing is stopping you from opening a PR. Anything you push to AngularUI doesn't really help us move forwards.

Dean Sofer
DeanSofer.com
714.900.2254

On Wednesday, April 17, 2013 at 12:27 PM, Arnaud BRETON wrote:

I think these kind of issues are requirements for people to actively develop on this project right?
I think I will start to backport my patch on angular-ui first and do it when ui-utils will be more mature.
Yes I used this param too for Karma, but it's not a big deal to precise a default one, mainly for the future grunt task.

—
Reply to this email directly or view it on GitHub (#7 (comment)).

[arnaudbreton]

I'm agree with you that most of the issues can be easily bypass but they require some setup time that I can't dedicate to this project for the moment (but I would like!).
The one about the jQuery dependency has to be solved quickly and like you I haven't any idea on how to create an event without jQuery API (I have seen not straightforward examples to do that with pure JS implementation, I can find them back I guess).

In my opinion to attract people to develop actively on the project, write specs, etc, initial environment has to be "plug&play".
For example, the doc is a little bit outdated:

• Grunt should not be globally installed (http://gruntjs.com/getting-started),
• Why coffee script is required? I haven't seen coffee files so far,
• Testacular is now known as Karma.

It's definitely not a big deal but it have to be done for the Grunt task, isn't it?

I will be glad to contribute to this project but just considering the small amount of time that I can spend on it.

Let me know how I can help.

[ProLoser]

I updated the README.md so you should not have too much difficulty hacking on this project. I have been busy running around that I have not had time to update the instructions as they may be subject to change.

[ProLoser]

After a little poking around it looks like jQuery is only a dependency for the spec files. I decided that for now I'm going to make jQuery a development dependency and will try to eventually remove it from the specs too, however this should not affect the actual source files. I may be wrong though as I need to confirm.

Good news is that all tests pass now!

[arnaudbreton]

Awesome! Glad to hear. It thought about it, it sounds reasonable for test needs.
The Web is still not fully ready to go over jQuery :).

I am on a critical issue on our app right now but I will go back to the backport ASAP.

Best.