rules_typescript doesn't give an error when used with a wrong version of rules_nodejs

[angular]

rules_typescript doesn't give an error when used with a wrong version of rules_nodejs

[jelbourn]

Okay, I can make this happen pretty consistently. Seems to happen when I bazel clean, build one ts_library, then build an unrelated ts_library

[jelbourn]

Weirdly changing to ng_module seems to prevent this

[alexeagle]

ts_library uses @build_bazel_rules_typescript//internal/tsc-wrapped as its compiler, and this should always have the flag --expose-gc passed to node.
https://github.com/bazelbuild/rules_typescript/blob/master/internal/tsc_wrapped/BUILD.bazel#L53

I think this is never working, and only once you have a ts worker where the cache has filled to some threshold, do we try to call the gc.

I don't see why ng_module would be any better, unless maybe you don't have
build --strategy=AngularTemplateCompile=worker so you're not using workers for ngc-wrapped?

[alexeagle]

I tried to repro by checking for global.gc at the top-level of worker.ts, but it works for me. Let's debug it tomorrow.

[jelbourn]

Resolved by updating

[alexeagle]

Root cause here was that rules_nodejs had a breaking change, and so you need to use a recent rules_typescript.
But rules_nodejs is published as a bazel workspace dependency (since it bootstraps the bazel run @yarn//:yarn) and rules_typescript is published as a npm dependency.
Still, the ts_library rule could probably load a constant value from somewhere that gives the version of rules_nodejs and give a useful error message if the versions are skewed.

[alexeagle]

Have a fix for this proposed, https://github.com/alexeagle/bazel_example_new

We still only pick up the top-level node_modules/@bazel/javascript though - so if you have @bazel/typescript depends on @bazel/[email protected] but you also installed @bazel/[email protected] we will end up using 1.0 even if that means rules_typescript doesn't work...

[alexeagle]

rules_typescript now checks the version of rules_nodejs
https://github.com/bazelbuild/rules_typescript/blob/81114490287357c34f1e632c2e96abea611bf8ff/internal/ts_repositories.bzl#L47
so as long as we keep that up to date, it should solve this issue.