Giter Site home page Giter Site logo

Comments (5)

vojtajina avatar vojtajina commented on March 29, 2024

There is a lot of refactoring that needs to be done. What you are saying makes totally sense.

  • separate transformers into classes
  • create two compiler classes (es6+A to dart, es6+A to es5)

and more...

from angular.

vicb avatar vicb commented on March 29, 2024

I have self-assigned this ticket.
Not sure to get what you mean about the two compiler classes. Currently there is a single class that can generate both ES5 and Dart according to the outputLanguage option, what would be the purpose of having 2 different classes ?

from angular.

vicb avatar vicb commented on March 29, 2024

@vojtajina I have closed this issue by pushing the refactoring fix to master (I think it's great to have this in master now to build upon it). You should probably create a new issue is more refactoring is needed. Thanks.

from angular.

tbosch avatar tbosch commented on March 29, 2024

+1 for keeping only one Compiler that does different things based on
outputLanguage, as traceur already does this for outputLanguage es5 and es6
(the latter only removes annotations and types)...

On Tuesday, September 30, 2014, Victor Berchet [email protected]
wrote:

@voltajina I have closed this issue by pushing the refactoring fix to
master (I think it's great to have this in master now to build upon it).
You should probably create a new issue is more refactoring is needed.
Thanks.


Reply to this email directly or view it on GitHub
#24 (comment).

from angular.

angular-automatic-lock-bot avatar angular-automatic-lock-bot commented on March 29, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

from angular.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.