Comments (5)
There is a lot of refactoring that needs to be done. What you are saying makes totally sense.
- separate transformers into classes
- create two compiler classes (es6+A to dart, es6+A to es5)
and more...
from angular.
I have self-assigned this ticket.
Not sure to get what you mean about the two compiler classes. Currently there is a single class that can generate both ES5 and Dart according to the outputLanguage
option, what would be the purpose of having 2 different classes ?
from angular.
@vojtajina I have closed this issue by pushing the refactoring fix to master (I think it's great to have this in master now to build upon it). You should probably create a new issue is more refactoring is needed. Thanks.
from angular.
+1 for keeping only one Compiler that does different things based on
outputLanguage, as traceur already does this for outputLanguage es5 and es6
(the latter only removes annotations and types)...
On Tuesday, September 30, 2014, Victor Berchet [email protected]
wrote:
@voltajina I have closed this issue by pushing the refactoring fix to
master (I think it's great to have this in master now to build upon it).
You should probably create a new issue is more refactoring is needed.
Thanks.—
Reply to this email directly or view it on GitHub
#24 (comment).
from angular.
This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.
from angular.
Related Issues (20)
- Unable to react to an API response. HOT 6
- Ability to disable "NG3: The containing function or module body is too large for control flow analysis. [plugin angular-compiler]" rule HOT 4
- Failed to implement CSP Policy's for styles with CSP_NONCE token HOT 2
- Animation in not active material mat-tab makes animated element get stuck in the DOM
- Error Application start, functional guard injection in the app_routes_config HOT 8
- Provide typesafety for ComponentRef.setInput HOT 1
- Paste output is not triggered when input is not empty (at least in Firefox) HOT 6
- Can we exclude specific routes for useHash routing? HOT 1
- docs(aot): Type Narrowing Code Sample is Duplicated HOT 1
- `ModelSignal.asReadonly()` returns value instead of readonly signal
- Twitter name Changing HOT 1
- Copy button of code example on angular.dev blocks the code HOT 3
- Using Self-Closing Tags on root-element (app-root) breaks SSR HOT 1
- Angular 13 to 14 migration issue running widgets HOT 2
- input's initialValue value ignored with withComponentInputBinding() HOT 1
- addEventListener with AbortSignal option can cause memory leaks HOT 1
- API reference list link missing. HOT 1
- The sentence on the document confuses me HOT 1
- TypeScript Infinity and NaN errors HOT 1
- provideClientHydration() shouldn't cache HttpClient GET requests with "Authorization" header HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from angular.