Enum values translated incorrect if using namespace

[lgemeinhardt]

Enum values translated incorrect if using namespace

[frost-cy]

Created Google internal issue http://b/236797164

[frost-cy]

Triage: As it is the externs, we strip the string values. May I know why this is an issue?

[lgemeinhardt]

I try to use tsickle to move some mappings from https://github.com/DefinitelyTyped/DefinitelyTyped to closure externs and afterwards using https://github.com/google/jsinterop-generator to GWT.
My first try was the google.maps mapping (https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/google.maps/), because I could compare this to the given extern (https://github.com/google/closure-compiler/tree/master/contrib/externs/maps) and was concerned about the difference (assuming the values for enum numbers and strings are needed later on for the JsInterop for GWT).

[mprobst]

assuming the values for enum numbers and strings are needed later on for

the JsInterop for GWT Are they though? I don't know how jsinterop processes these, but given string literal types are not a feature in Closure Compiler, I would expect that not to matter.

[lgemeinhardt]

@mprobst Thanks for your answer, but if the closure compiler not supports this types - why the enum test case https://github.com/angular/tsickle/tree/master/test_files/enum has a sample (StringEnum ) for it (correctly converted)? Only difference I see to my sample is the namespace.

[mprobst]

The code you link to isn't externs, i.e. it's not produced from a `.d.ts`. In that code, we do care about the actual value, because it's part of the app (and it'd break if we left the enum values out). `.d.ts` and ***@***.***` are special because they describe code that is not part of your app.

[lgemeinhardt]

@mprobst Thanks for the quick clarification.
It sounds tsickle does this on purpose (even if it looks strange, that enum number values are all 1 and enum strings values are all empty and the generated externs looks different, then the official once from closure-compiler externs).
I will check if jsinterop-generator could produce valid mappings and will close this issue afterwards.

[lgemeinhardt]

Looks like jsinterop-generator works w/o enum values.