Upgrade this repo and add support to Jasmine 3.3

[IgorMinar]

Upgrade this repo and add support to Jasmine 3.3

[JiaLiPassion]

@IgorMinar, sure, I will take a look
@johnjbarton, if you can provide some error information you got, it will be greatly helpful.
Thanks.

[IgorMinar]

awesome! thanks @JiaLiPassion

[johnjbarton]

First a couple of hints: our jasmine 3.3 upgrade hit two bumps: the default for tests is now 'random' and the configuration API changed resulting in some mysterious fails. After that we got stuck on fails from code that uses zonejs. I don't know the code involved; the stack I see is:

Chrome 71.0.3578 (Linux 0.0.0): error TypeError: Cannot read property 'apply' of undefined
TypeError: Cannot read property 'apply' of undefined
    at ZoneDelegate.invokeTask (...zone_js/v0_8_21/lib/zone.js:408:31)
    at Zone.runTask (.../zone_js/v0_8_21/lib/zone.js:175:47)
    at drainMicroTaskQueue (.../zone_js/v0_8_21/lib/zone.js:582:35)

[JiaLiPassion]

@johnjbarton, is there any reproduce repo I can access? Thanks!

[johnjbarton]

Sorry, it's not my code, but I passed your request along.

[JiaLiPassion]

@johnjbarton, thanks, the only breaking changes of jasmine 3.3 I knew is nodejs process.unhandledRejection handling, I will also upgrade jasmine to 3.3 in zone.js repo.

And also you may try to set random: false in jasmine config to check whether this issue still there or not.

[johnjbarton]

The code that fails for us currently runs on jasmine 2.9. So the delta we are working with is 3.3-2.9 rather than 3.3-3.2. (We've already set random: false for our 3.3 attempts; also note we are running against your 0.8.21 which I don't control).

Note that the stacktrace I listed above is from code that involves testing errors in async functions.

[IgorMinar]

I suggest we update angular/zone.js, angular/angular, and angular/angular-cli repos to jasmine 3.3 before we try to figure out this google3 specific failure. It's possible that the issue is unrelated to Jasmine 3.3 and zone.js integrations (in google3 we have a project called Catalyst that sits between zone.js and jasmine, so that could be a culprit). So let's do the updates first, if we come across the issue let's fix it, if not then we have a smaller surface are to deal with to investigate the failure in google3.

…

On Thu, Feb 7, 2019 at 9:42 AM johnjbarton ***@***.***> wrote: The code that fails for us currently runs on jasmine 2.9. So the delta we are working with is 3.3-2.9 rather than 3.3-3.2. (We've already set random: false for our 3.3 attempts; also note we are running against your 0.8.21 which I don't control). Note that the stacktrace I listed above is from code that involves testing errors in async functions. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1184 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AANM6KBG0JwiwDdHpdNsm2aYaBxe0VlMks5vLGWNgaJpZM4akXZV> .

[christophercr]

Question: is #1185 related to this issue? if so, would that mean that Jasmine 3.3 is now supported in angular/zone.js v0.9.0?

[JiaLiPassion]

@christophercr, yes, zone.js 0.9.0 now support jasmine 3.3, if you find any issues, please report here, thanks!

[JiaLiPassion]

I will close this one for now, unless we found new issues for jasmine 3.3