Problem with ENUMS when UnitAbbreviationsCache.Default.GetDefaultAbbreviation is use.

[farenasmz]

Problem with ENUMS when UnitAbbreviationsCache.Default.GetDefaultAbbreviation is use.

[angularsen]

Merged and should be out as nuget shortly.

Release UnitsNet/5.30.0 · angularsen/UnitsNet

[angularsen]

Hi, what version are you on? I see you are using QuantityType and it was removed in v5.
I updated your code to v5, but it still fails.

I believe it boils down to casting to Enum and the lookup fails as shown in CastToEnum_Fails(), but GenericEnum_Ok() passes.

using System;
using Xunit;

namespace UnitsNet.Tests;

public class GasFlowTests
{
    public GasFlowTests()
    {
         UnitAbbreviationsCache.Default.MapUnitToDefaultAbbreviation(GasFlowRateUnit.StandardCubicMetersPerDay, "m³/d");
         UnitAbbreviationsCache.Default.MapUnitToDefaultAbbreviation(GasFlowRateUnit.ThousandStandardCubicFeetPerDay, "kft³/d");
    }

    [Fact]
    public void GenericEnum_Ok()
    {
        Assert.Equal("m³/d", UnitAbbreviationsCache.Default.GetDefaultAbbreviation(GasFlowRateUnit.StandardCubicMetersPerDay));
    }

    [Fact]
    public void CastToEnum_Fails()
    {
        Assert.Equal("m³/d", UnitAbbreviationsCache.Default.GetDefaultAbbreviation((Enum)GasFlowRateUnit.StandardCubicMetersPerDay));
    }

    public enum GasFlowRateUnit
    {
        StandardCubicMetersPerDay = 1,
        ThousandStandardCubicFeetPerDay = 2,
    }
}

System.ArgumentException: Type provided must be an Enum.

System.ArgumentException
Type provided must be an Enum.
   at System.Enum.GetEnumInfo(RuntimeType enumType, Boolean getNames)
   at System.RuntimeType.GetEnumName(Object value)
   at UnitsNet.UnitAbbreviationsCache.TryGetUnitAbbreviations(Type unitType, Int32 unitValue, IFormatProvider formatProvider, String[]& abbreviations) in C:\dev\unitsnet\UnitsNet\CustomCode\UnitAbbreviationsCache.cs:line 246
   at UnitsNet.UnitAbbreviationsCache.GetUnitAbbreviations(Type unitType, Int32 unitValue, IFormatProvider formatProvider) in C:\dev\unitsnet\UnitsNet\CustomCode\UnitAbbreviationsCache.cs:line 231
   at UnitsNet.UnitAbbreviationsCache.GetDefaultAbbreviation(Type unitType, Int32 unitValue, IFormatProvider formatProvider) in C:\dev\unitsnet\UnitsNet\CustomCode\UnitAbbreviationsCache.cs:line 204
   at UnitsNet.UnitAbbreviationsCache.GetDefaultAbbreviation[TUnitType](TUnitType unit, IFormatProvider formatProvider) in C:\dev\unitsnet\UnitsNet\CustomCode\UnitAbbreviationsCache.cs:line 190
   at UnitsNet.Tests.GasFlowTests.CastToEnum() in C:\dev\unitsnet\UnitsNet.Tests\GasFlowTests.cs:line 26
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)

I took a quick look and found that the lookup implementation incorrectly tries to do typeof() on the generic type, but when passing Enum that type information is lost.

A fix is on the way in #1302.

[farenasmz]

Hi @angularsen! thanks for your answer I'm using 4.132.0

[angularsen]

@farenasmz are you able to try the latest v5 nuget and see if that helps? You may have to migrate some usages.

https://github.com/angularsen/UnitsNet/wiki/Upgrading-from-4.x-to-5.x