Comments (24)
I believe the reason is because the .ts
is missing in this:
https://github.com/angulartics/angulartics2/blob/master/tsconfig.json#L22-L25
from angulartics2.
Yes just realised it. Not sure why but tsc -d
is not creating the .js files.
Tried your tip but no luck.
from angulartics2.
That PR will fix it... definitely generates the .js for those files now for me locally.
from angulartics2.
Btw, if you want to add me as collaborator here and on npm for this, I can help with this kind of stuff in the future.
from angulartics2.
Sure will ask for you to be added. Just need to ask angularitics guys.
Thanks for your help.
from angulartics2.
Files are still missing from latest build.
from angulartics2.
They are still not there, I see that with 1.0.4, very strange. Are they there when you build and before you publish?
from angulartics2.
Basically:
npm run build
Look in src/providers
, are the .js files there?
If yes, bump version, then:
npm publish
Should do it.
If there are not there, then there must be errors resulting when running npm run build
that are preventing the provider files from compiling?
from angulartics2.
npm run build
is working locally
Release process should work with semantic-release in travis.
from angulartics2.
I think this: #19 will finally solve it.
from angulartics2.
I am up for trying any idea at this point. :/
from angulartics2.
Ok I didn't know you are relying on sematic release, you will need to change this then in package.json
:
"semantic-release": "semantic-release pre && npm publish && semantic-release post"
I would have added that in my PR... anyway just change that ^ to this...
"semantic-release": "npm run build && semantic-release pre && npm publish && semantic-release post"
pretty sure that would do it
from angulartics2.
Oh yes that should be it.
Thanks again.
from angulartics2.
Well wow still not it. Ok it takes a lot, and I mean a lot to make me quit, so we will solve this thing... maybe it needs this:
"semantic-release": "semantic-release pre && npm run build && npm publish && semantic-release post"
May require pre
be first.
from angulartics2.
trying it.
from angulartics2.
Hooray!! it worked!
from angulartics2.
Well we both learned something very important 👍
from angulartics2.
Great!! Yes now I can fix two other libraries. Big thanks.
from angulartics2.
I need to start using semantic-release
myself but yeah I guess it's paramount that pre
be the first out the gate to execute (which makes sense if you think about it)... anyhow, this looks much better now!
And I love this lib, so def wanna make it as tight as possible!
from angulartics2.
Sorry about these bugs... I am very new to all this (angular2, observables, typescript...) learning all atm. I am bound to make these mistakes at first. Good to have some help :)
from angulartics2.
N/p at all, I'm new to them as well and have been making mistakes myself in several places.
The idiosyncrasies with publishing and developing the lib make for some serious confusion at times.
We're getting there! ... together 👍
from angulartics2.
Added you as collaborator.
from angulartics2.
Thx! I'll help tighten and review when I can and as always would put stuff up for review before making any changes, cheers!
from angulartics2.
Can you talk (https://gitter.im/angulartics/angulartics2) one minute? I would like to run an issue through you.
from angulartics2.
Related Issues (20)
- Allow extra information for Page method in Angulartics2Segment
- Custom Properties not working in Google Tag Manager HOT 1
- G4 in the new version of google analytics HOT 8
- The automated release is failing 🚨 HOT 1
- Matomo string value not processed properly HOT 1
- Angular 13 support HOT 1
- Which version to use for Angular 11.2.0? HOT 1
- Google analytics page view
- Mask the ids from the urls when I'm tracking pages
- Matomo : When resetUser() is fired then each futur event is tracked in a distinct visit HOT 1
- Dependency conflict between angulartics 11 and rxjs 6 HOT 1
- UI-Router Documentation HOT 1
- Angular 14 support HOT 6
- Getting duplicated entry in matomo backend.
- Support for standalone components HOT 2
- setUserProperties to GA could be setup with 'user_properties'
- Need more details to inject angularics2On directives in Angular v12
- Suport for new version Google Analytics 4 HOT 3
- Angulartics ivy support
- prerenderring - Angulartics2BaiduAnalytics ReferenceError: _hmt is not defined
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from angulartics2.