Comments (5)
Thanks for reporting!
I happened to notice something similar but wasn't sure if it was just my hacked version of OSX - looks like actual OSX has the same (weird) issue.
Could you give the following a try?
In src/common.h, find
#if defined(__cplusplus) && __cplusplus > 201100 && !(defined(_MSC_VER) && defined(__clang__))
replace with
#if defined(__cplusplus) && __cplusplus > 201100 && !(defined(_MSC_VER) && defined(__clang__)) && !defined(__APPLE__)
See if that works for you.
I got another issue with _lzcnt_u32
not being found. I added the following to the same file, just before the last line (#endif /* __YENC_COMMON */
):
// weird thing with Apple's Clang
#if defined(__clang__) && defined(__APPLE__)
# define _lzcnt_u32 __lzcnt32
#endif
from node-yencode.
In src/common.h, find
#if defined(__cplusplus) && __cplusplus > 201100 && !(defined(_MSC_VER) && defined(__clang__))
replace with
#if defined(__cplusplus) && __cplusplus > 201100 && !(defined(_MSC_VER) && defined(__clang__)) && !defined(__APPLE__)
See if that works for you.
Builds. Thanks a lot.
I got another issue with
_lzcnt_u32
not being found. I added the following to the same file, just before the last line (#endif /* __YENC_COMMON */
):// weird thing with Apple's Clang #if defined(__clang__) && defined(__APPLE__) # define _lzcnt_u32 __lzcnt32 #endif
Did not encounter.
Adding it (combined with the previous suggestion) does still compile.
from node-yencode.
Thanks a lot for confirming and testing the second edit!
from node-yencode.
Could you please cut a new release with this fixed.
That way macOS users can simply get it from NPM and automatically stay updated (instead of manually checking our manual builds).
from node-yencode.
Yes definitely. Sorry for the delay.
NPM module should now be at v1.1.1
from node-yencode.
Related Issues (12)
- Please Create CRC checksum's HOT 2
- CLI options? HOT 3
- Python bindings HOT 25
- Building for Go HOT 7
- Clarification on `column_offset` parameter for `encode` and `encodeTo` HOT 2
- Critical characters not escaped when they are the last character of the segment HOT 1
- yEnc SSE decode ideas HOT 54
- Build fails with node.js 12.7.0 HOT 3
- Unable to build or install HOT 2
- Errors trying to install yencode HOT 1
- Trying to install yencode: "npm WARN saveError ENOENT: no such file or directory, open '/home/sander/package.json'" HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node-yencode.