Giter Site home page Giter Site logo

Comments (52)

Akanksha1212 avatar Akanksha1212 commented on May 18, 2024 1

Hi! Can I work on this?

from anitab-org.github.io.

Sonal240 avatar Sonal240 commented on May 18, 2024 1

@Akanksha1212 I've updated the issue kindly have a look and do the necessary changes in the code

from anitab-org.github.io.

Akanksha1212 avatar Akanksha1212 commented on May 18, 2024 1

Hi @Sonal240 and @sakshi1499, I think it would be better if someone else takes it up for now. I am pretty new to this so need some time to figure it out. I'll try to look for simpler issues πŸ˜…

from anitab-org.github.io.

anna4j avatar anna4j commented on May 18, 2024 1

@sakshi1499 I can take it up :) could you also see the changes in my latest pr please

from anitab-org.github.io.

anna4j avatar anna4j commented on May 18, 2024 1

@sakshi1499 hey! currently stuck on this issue. There isn't a lot of documentation around this either. I did tag the coding team in zulip because I read an article by an open-source contributor at systers 2 years ago and they had implemented a similar feature in their systers.github.io but I tried everything she shared and it doesn't work :(
In fact, I went ahead and mailed her too. Waiting for a lead on this now

from anitab-org.github.io.

Sonal240 avatar Sonal240 commented on May 18, 2024 1

Have you tried filtering the latter response according to labels? Similar to this one https://devdocs.magento.com/guides/v2.4/rest/retrieve-filtered-responses.html ...@anna4j

from anitab-org.github.io.

anna4j avatar anna4j commented on May 18, 2024 1

@Sonal240 okay, that's pretty cool but still please do make it available so that someone else can give it a try. I'm not 100% sure if I'll be able to crack it that's why :)

from anitab-org.github.io.

parthsarthiprasad avatar parthsarthiprasad commented on May 18, 2024 1

Hi, @nandini45 Can I take up this issue, I'd like to work on this, if possible. Thanks.

from anitab-org.github.io.

parthsarthiprasad avatar parthsarthiprasad commented on May 18, 2024 1

Yep, I understand your concern. I am comfortable with JavaScript, I'll read through the source code and try to do the necessary.

from anitab-org.github.io.

anna4j avatar anna4j commented on May 18, 2024 1

@parthsarthiprasad so initially I had started out with the iframe approach as well. And tried using the community-toolbox by public labs. But there are few issues regarding GitHub security as they don't allow their content to be displayed in iframe

This PR dealsΒ  with the same: systers/systers.github.io#263

This is from two years ago when systers.io team was implementing first timer issues in their website. They had used iframe, but were also considering another approach, do give it a read.

In my opinion, you could give iframe approach a try you might have to install react-iframe and tweak around a little bit
But ultimately for a more dynamic solution using GitHub API is a good option. And yes you're right it'll give a json response of all repo issues we'll have to filter out those issues by label and create a template UI

from anitab-org.github.io.

nandini45 avatar nandini45 commented on May 18, 2024 1

@paritoshsinghrahar any updates?

from anitab-org.github.io.

sakshi1499 avatar sakshi1499 commented on May 18, 2024

LGTM @Sonal240 Awesome work πŸ’―

from anitab-org.github.io.

Sonal240 avatar Sonal240 commented on May 18, 2024

@anitab-org/coding-team kindly take up this issue... Thanks

from anitab-org.github.io.

Sonal240 avatar Sonal240 commented on May 18, 2024

Anyone from @anitab-org/coding-team free to take up this issue??

from anitab-org.github.io.

Sonal240 avatar Sonal240 commented on May 18, 2024

The issue is open for all

from anitab-org.github.io.

sakshi1499 avatar sakshi1499 commented on May 18, 2024

@Akanksha1212 Hi what are the updates? Are you still working on this issue?

from anitab-org.github.io.

Akanksha1212 avatar Akanksha1212 commented on May 18, 2024

Hi @sakshi1499 Yes, I am working on it. Will make a PR in 1-2 days.

from anitab-org.github.io.

sakshi1499 avatar sakshi1499 commented on May 18, 2024

@Akanksha1212 Great

from anitab-org.github.io.

Sonal240 avatar Sonal240 commented on May 18, 2024

@Akanksha1212 can you submit a pr...thanks

from anitab-org.github.io.

Akanksha1212 avatar Akanksha1212 commented on May 18, 2024

Hi @Sonal240, I spent time working on this issue but I am not getting the exact result as it's expected in the issue. So I don't think I'll be able to make a PR soon. Please unassign me.

from anitab-org.github.io.

sakshi1499 avatar sakshi1499 commented on May 18, 2024

@Akanksha1212 Its okay if its taking you time, you can take some more time not an issue.

from anitab-org.github.io.

Sonal240 avatar Sonal240 commented on May 18, 2024

Hey @Akanksha1212 you may pose questions here as well no issues... I just asked about the pr coz you had mentioned it earlier...

from anitab-org.github.io.

anna4j avatar anna4j commented on May 18, 2024

@sakshi1499 @Sonal240 I have to feature issues of which GitHub repository in this component? anitab-org.github.io?

from anitab-org.github.io.

Sonal240 avatar Sonal240 commented on May 18, 2024

All the issues that have the label first timer issue only for all repositories if possible

from anitab-org.github.io.

sakshi1499 avatar sakshi1499 commented on May 18, 2024

@anna4j So as much as I got it, I believe you need help with embedding first timer issue in the code?

from anitab-org.github.io.

anna4j avatar anna4j commented on May 18, 2024

@sakshi1499 yes absolutely

from anitab-org.github.io.

sakshi1499 avatar sakshi1499 commented on May 18, 2024

@anna4j give me some time, i'll do my research and get to you. Give me a day max

from anitab-org.github.io.

sakshi1499 avatar sakshi1499 commented on May 18, 2024

@anna4j Hi, Read about GitHub Gists and Read about this Link. Tell me if it solves your problem!

from anitab-org.github.io.

anna4j avatar anna4j commented on May 18, 2024

@sakshi1499 ya, I've been trying out this approach! will update soon

from anitab-org.github.io.

nandini45 avatar nandini45 commented on May 18, 2024

@anna4j I have unassigned you from two issues. there are some guidelines you should abide by that is you can work on only one issue at a time and moreover i think it will be to much work for you to work on more than one issue. i see you opened one PR therefore you can continue working on this. and when you will complete it if that issue(which i have unassigned you) is still available you can take up that issue.!!

from anitab-org.github.io.

anna4j avatar anna4j commented on May 18, 2024

@sakshi1499 Hello! So I was playing around with the GitHub API to fetch issues and here some shortcomings I've faced:

  1. Only issues of a particular Repo can be fetched at once, but I guess one way around this is to call the function multiple times for various repos.
  2. All issues are fetched at the same time, I haven't been able to find a way to fetch them label-wise since we need "First Timers Only" issues
    How should I go about this?

from anitab-org.github.io.

anna4j avatar anna4j commented on May 18, 2024

@Sonal240 hey! could you please make this issue available again...I'm not able to implement it, but I tried :)

from anitab-org.github.io.

Sonal240 avatar Sonal240 commented on May 18, 2024

Just a query did you filter the json response...by using the second one by fetching all the issues at a time... @anna4j

You may give it another try if you want... It's your call...

from anitab-org.github.io.

anna4j avatar anna4j commented on May 18, 2024

@Sonal240 actually it will take me some time to do this, I've understood the logic and the link you sent also helped. But what's the deadline?

from anitab-org.github.io.

Sonal240 avatar Sonal240 commented on May 18, 2024

There's no deadline as such...

from anitab-org.github.io.

nandini45 avatar nandini45 commented on May 18, 2024

@anitab-org/coding-team can anyone take this up?

from anitab-org.github.io.

nandini45 avatar nandini45 commented on May 18, 2024

@parthsarthiprasad just one thing as this is you first issue. it is a little tricky or difficult issue i suppose. so if you are well versed with JavaScript then feel free to continue

from anitab-org.github.io.

parthsarthiprasad avatar parthsarthiprasad commented on May 18, 2024

@nandini45 just a design discussion, I was considering of implementation using an iframe, while I read above consideration about implementation using Github API above(which will serve only the data in JSON schema I suppose , which would require creating a template UI to show data like github, @anna4j ),
does the first sound good to you?( though Ill check if that will be feasible for different screen resolutions)

from anitab-org.github.io.

parthsarthiprasad avatar parthsarthiprasad commented on May 18, 2024

I think you tagged wrong guy? (Yeah sorry I've been little caught up in interviews lately so didn't get opportunity to work on this recently) ( holding on might cause delay, if no-one else picks up this. I'd complete this later on, presently I can't give enough precedence )

from anitab-org.github.io.

nandini45 avatar nandini45 commented on May 18, 2024

oh i am so sorry.
so should i make it available for other contributors?

from anitab-org.github.io.

rutvi18 avatar rutvi18 commented on May 18, 2024

Can I take up this issue?

from anitab-org.github.io.

Akanksha1212 avatar Akanksha1212 commented on May 18, 2024

Sure @rutvi18. Go ahead!

from anitab-org.github.io.

Akanksha1212 avatar Akanksha1212 commented on May 18, 2024

How is it going? @rutvi18 Let us know if you need any help

from anitab-org.github.io.

rutvi18 avatar rutvi18 commented on May 18, 2024

I am working on it. It got delayed due to other commitments. Will request for PR in 2-3 days.

from anitab-org.github.io.

rutvi18 avatar rutvi18 commented on May 18, 2024

@Akanksha1212 I have done few updates. Please check my PR. But ,still I am not able to add png files under contribute tab. Please guide for same.

from anitab-org.github.io.

annabauza avatar annabauza commented on May 18, 2024

@tichnas I release this issue due to lack of response.

from anitab-org.github.io.

iamkryptonite avatar iamkryptonite commented on May 18, 2024

Is this issue still available? I would like to give it a try .

from anitab-org.github.io.

nandini45 avatar nandini45 commented on May 18, 2024

sure @iamkryptonite i will assign you the issue

from anitab-org.github.io.

iamkryptonite avatar iamkryptonite commented on May 18, 2024

Hey @nandini45 I have a few questions:

  1. Since we are only showing the 'first timer issues' is the 'label' heading in the table required?
  2. What happens when I click on one of the issues?

from anitab-org.github.io.

iamkryptonite avatar iamkryptonite commented on May 18, 2024
  1. Also the table headings have arrows which I guess are dropdowns. Do they work exactly like the ones shown in Github? Like for example if we click on sort and select an option from the drop-down does it sort the list of first time issues accordingly?

from anitab-org.github.io.

nandini45 avatar nandini45 commented on May 18, 2024

@iamkryptonite
1.it was used only for searching any specific category of work. for example- all will be 1st timer issue along with it the category will be coding specific.
although if you want to ,you can remove it .
2.it will redirect the user to that issue.
3.instead of making several dropdown . like labels milestone etc.
just go for one i.e. assignee one to show that it is taken or not

but now when u asked these question i had a question that you may design it for now. but what after when those issues have been solved. is there any way by which we can fetch new issues in it?

from anitab-org.github.io.

iamkryptonite avatar iamkryptonite commented on May 18, 2024

@nandini45 The issues will be dynamically generated from the github api itself and will get updated automatically. We don't need to add issues every time a new issue is created.

from anitab-org.github.io.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.