Comments (17)
That's OK, @Aaishpra . I'll assign you to this one then. Thanks for letting me know. 👍
from bridge-in-tech-web.
hey can u assign this to me @meenakshi-dhanani
from bridge-in-tech-web.
@Aaishpra . You've already been assigned to issue #66 . So, we'll keep this one open for others to pickup. 😁
from bridge-in-tech-web.
sorry, @mtreacy002 I guess I wouldn't be able to work on that but this issue belongs to my field of knowledge and I will be able to work on this so please assign this to me and I have already unassigned from #66 .
Sorry for inconvenience
from bridge-in-tech-web.
@Aaishpra. Can you please give an update on your progress on this issue? Just in case you need help with anything. 😉
from bridge-in-tech-web.
Hey @mtreacy002 sorry for no updates still working on that i think it will be completed in 2 days and i will make a pr then .
from bridge-in-tech-web.
No worries, @Aaishpra . Just checking because I'm tidying up the repository atm. Take your time 😉
from bridge-in-tech-web.
@mtreacy002 do i need to make seprate tests for testing seprate fields
from bridge-in-tech-web.
@Aaishpra, I think it's best to have them separate, since on the UI, the warning will be given on the first incorrect field found. For example, if the name and the username are wrong, the warning only will show that the name is wrong, the username is not checked. If the name is then corrected, then it'll check for the next field which is username. Does this make sense?
cc @meenakshi-dhanani , do we want to check this on all the required fields that have validation in place or two or three tests will suffice? Imo few tests should do at this stage. Let me know what you think.
from bridge-in-tech-web.
Yes sure will make seprate tests for each field
from bridge-in-tech-web.
Although, @Aaishpra . You could also do one for all fields in one test where the error message are shown in red text per each field (see screenshot below)
Notice that a warning that check for blank fields comes one field at a time from the first error field found.
So, perhaps do one for the input validation for all fields (with red error texts) and one for an empty field warning. What do you think?
from bridge-in-tech-web.
@mtreacy002 I couldn't find where this warning for the empty field " Please fill in this field " is written. Can u help me with this?
from bridge-in-tech-web.
@Aaishpra . That comes from the use of html required
attribute as shown in the code below
@testing-library/jest-dom has .toBeRequired() to check this attribute. Hope this helps 😉
from bridge-in-tech-web.
Don't know why I am getting this, In my view there is only one element that contains placeholder "Username"
from bridge-in-tech-web.
@Aaishpra , there's an example on PersonalDetails.test.js line 51 on how to use getByLabelText narrowing down using the selector
Noticed that in PersonalDetails.jsx, the label
is used with id
instead of htmlFor
and input
has an aria-labelledBy
attribute to make the referencing works. Can you give this a try and see of it works.
from bridge-in-tech-web.
@Aaishpra, if you could send a PR with the current code you have (it doesn't matter if it's not quite right yet, you could add label WIP | ...<PR title>
at the beginning of your PR, to help give me a clearer picture on where your code might have gone wrong. Can you do that?
from bridge-in-tech-web.
Done @mtreacy002
from bridge-in-tech-web.
Related Issues (20)
- UI: Develop Homepage - Video section HOT 15
- UI: Develop Homepage - Benefits section HOT 5
- UI: Develop Homepage - Read about us section HOT 11
- UI: Develop Homepage - FAQ section HOT 12
- UI: Develop Homepage - Get In Touch section HOT 22
- UI: Develop Homepage - Footer section HOT 25
- Research: Using gh-pages as remote frontend HOT 13
- Research: Refactor useState() hooks to useReducer() HOT 17
- Task: Set up local environment HOT 24
- Dev: Add alternative homepage for remote deployment | URGENT HOT 14
- Bug: Test failed after Link tag is used to replace anchor tag in Register.jsx and Login.jsx HOT 9
- UI: Develop Sign Up page HOT 8
- UI: Develop Sign In page HOT 15
- UI: Temporary side navigation for protected pages HOT 9
- Dev: Move GetInTouch files into home folder HOT 2
- Bug: Sidebar icons on minimized/closed position are not linked to relevant pages HOT 11
- Dev: Add BIT backend heroku servers to BIT frontend as REST endpoints
- Chore: Update package.lock-json to match the dependencies inside package.json
- SignIn and SignUp page UI inconsistency HOT 4
- the logo has been crashed HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bridge-in-tech-web.