Test: Write tests for input validations on the Register form

[anitab-org]

Test: Write tests for input validations on the Register form

[mtreacy002]

That's OK, @Aaishpra . I'll assign you to this one then. Thanks for letting me know. 👍

[Aaishpra]

hey can u assign this to me @meenakshi-dhanani

[mtreacy002]

@Aaishpra . You've already been assigned to issue #66 . So, we'll keep this one open for others to pickup. 😁

[Aaishpra]

sorry, @mtreacy002 I guess I wouldn't be able to work on that but this issue belongs to my field of knowledge and I will be able to work on this so please assign this to me and I have already unassigned from #66 .
Sorry for inconvenience

[mtreacy002]

@Aaishpra. Can you please give an update on your progress on this issue? Just in case you need help with anything. 😉

[Aaishpra]

Hey @mtreacy002 sorry for no updates still working on that i think it will be completed in 2 days and i will make a pr then .

[mtreacy002]

No worries, @Aaishpra . Just checking because I'm tidying up the repository atm. Take your time 😉

[Aaishpra]

@mtreacy002 do i need to make seprate tests for testing seprate fields

[mtreacy002]

@Aaishpra, I think it's best to have them separate, since on the UI, the warning will be given on the first incorrect field found. For example, if the name and the username are wrong, the warning only will show that the name is wrong, the username is not checked. If the name is then corrected, then it'll check for the next field which is username. Does this make sense?

cc @meenakshi-dhanani , do we want to check this on all the required fields that have validation in place or two or three tests will suffice? Imo few tests should do at this stage. Let me know what you think.

[Aaishpra]

Yes sure will make seprate tests for each field

[mtreacy002]

Although, @Aaishpra . You could also do one for all fields in one test where the error message are shown in red text per each field (see screenshot below)

Notice that a warning that check for blank fields comes one field at a time from the first error field found.

So, perhaps do one for the input validation for all fields (with red error texts) and one for an empty field warning. What do you think?

[Aaishpra]

@mtreacy002 I couldn't find where this warning for the empty field " Please fill in this field " is written. Can u help me with this?

[mtreacy002]

@Aaishpra . That comes from the use of html required attribute as shown in the code below

@testing-library/jest-dom has .toBeRequired() to check this attribute. Hope this helps 😉

[Aaishpra]

Don't know why I am getting this, In my view there is only one element that contains placeholder "Username"

[mtreacy002]

@Aaishpra , there's an example on PersonalDetails.test.js line 51 on how to use getByLabelText narrowing down using the selector

Noticed that in PersonalDetails.jsx, the label is used with id instead of htmlFor and input has an aria-labelledBy attribute to make the referencing works. Can you give this a try and see of it works.

[mtreacy002]

@Aaishpra, if you could send a PR with the current code you have (it doesn't matter if it's not quite right yet, you could add label WIP | ...<PR title> at the beginning of your PR, to help give me a clearer picture on where your code might have gone wrong. Can you do that?

[Aaishpra]

Done @mtreacy002