Giter Site home page Giter Site logo

Comments (13)

ryanschiang avatar ryanschiang commented on June 18, 2024 11

Here's my workaround InfiniteScroll component, using IntersectionObserver:

interface InfiniteScrollProps {
  load: () => void;
  hasMore: boolean;
  loader: React.ReactNode;
  children?: React.ReactNode;
  endMessage?: React.ReactNode;
}

export const InfiniteScroll: React.FC<InfiniteScrollProps> = ({
  load,
  hasMore,
  loader,
  children,
  endMessage,
}) => {
  const sentinelRef = useRef<HTMLDivElement>(null);
  const observerRef = useRef<IntersectionObserver | null>(null);

  const handleIntersect = useCallback(
    (
      entries: IntersectionObserverEntry[],
      observer: IntersectionObserver
    ) => {
      // Check if the sentinel element is intersecting, and if so, call the load function
      if (entries[0].isIntersecting && hasMore) {
        load();
      }
    },
    [load]
  );

  useEffect(() => {
    // Create a new IntersectionObserver when the component mounts
    observerRef.current = new IntersectionObserver(handleIntersect, {
      root: null,
      rootMargin: "0px",
      threshold: 1.0,
    });

    // Attach the observer to the sentinel element
    if (sentinelRef.current) {
      observerRef.current.observe(sentinelRef.current);
    }

    // Clean up the observer when the component unmounts
    return () => {
      if (observerRef.current) {
        observerRef.current.disconnect();
      }
    };
  }, [load]);

  useEffect(() => {
    // When the hasMore prop changes, disconnect the previous observer and reattach it to the new sentinel element
    if (observerRef.current && sentinelRef.current) {
      observerRef.current.disconnect();
      observerRef.current.observe(sentinelRef.current);
    }
  }, [hasMore]);

  return (
    <div>
      {children}
      <div ref={sentinelRef}>{hasMore && loader}</div>
      {!hasMore && endMessage}
    </div>
  );
};

from react-infinite-scroll-component.

tofiqquadri avatar tofiqquadri commented on June 18, 2024 3

I avoided using this library since it has this major bug open and it has not yet solved.

Instead of this I used IntersectionObserver and implemented the functionality of this library myself.

from react-infinite-scroll-component.

tofiqquadri avatar tofiqquadri commented on June 18, 2024

@finishedcoot I still have this issue. What's the fix?

from react-infinite-scroll-component.

techwithanirudh avatar techwithanirudh commented on June 18, 2024

@finishedcoot I'm having the same issue? What's the fix?

from react-infinite-scroll-component.

techwithanirudh avatar techwithanirudh commented on June 18, 2024

@finishedcoot How could I use your fork without having yarn installed?

from react-infinite-scroll-component.

finishedcoot avatar finishedcoot commented on June 18, 2024

@techwithanirudh @tofiqquadri Temporarily you can install the package by changing your package.json to be like this and reinstall the module.
But I recommend to change it back after the maintainer fixed this issue ASAP.

"react-infinite-scroll-component": "git+https://github.com/Stacrypt/react-infinite-scroll-component",

from react-infinite-scroll-component.

LibardoVega avatar LibardoVega commented on June 18, 2024

hola yo pude resolver el hecho que no llame a la función "next", lo que me daba error era usar el componente dentro de una etiqueta que usara "Overflow: auto"

from react-infinite-scroll-component.

LibardoVega avatar LibardoVega commented on June 18, 2024

acabe de revisar bien la documentación y hace falta el "scrollableTarget" con eso ya pude usar el "Overflow: auto"

from react-infinite-scroll-component.

kimkong88 avatar kimkong88 commented on June 18, 2024

I am too waiting on this!

from react-infinite-scroll-component.

Fernando-Hooklab avatar Fernando-Hooklab commented on June 18, 2024

I'm having the same issue!

from react-infinite-scroll-component.

kimkong88 avatar kimkong88 commented on June 18, 2024

I'm having the same issue!

my workaround was just to fetch enough data for single page OR have each item card large enough to fit scroll.. OR load more manually(not waiting for scroll to reach the bottom) based on height

from react-infinite-scroll-component.

ryanschiang avatar ryanschiang commented on June 18, 2024

Issue still persists. See this codepen for example: https://codesandbox.io/s/amazing-hermann-x2qw8m?file=/src/index.js

Unfortunately this cripples the library for anything besides simple/single-page infinite scroll apps.

from react-infinite-scroll-component.

eamador avatar eamador commented on June 18, 2024

You can workaround this issue with a hook, check the following response

#391 (comment)

from react-infinite-scroll-component.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.