Giter Site home page Giter Site logo

Comments (5)

kevmodrome avatar kevmodrome commented on August 20, 2024 1

So - I think it's quite redundant to call them somethingSomethingAction - can I suggest maybe doing something like this:

For actions:
import { clickOutside } from 'svelte-legos/actions

and for the custom stores:
import { counter } from 'svelte-legos/stores

As soon as you use them in Svelte it's obvious what they are: use:x - it's an actions. $counter it's a store :)

from svelte-legos.

kevmodrome avatar kevmodrome commented on August 20, 2024

See, I was even confused by the naming convention. I assumed all the useX were actions, but looks like they are stores. Call them what they are, custom stores, not hooks.

And for the actions, remove the action part of the name

from svelte-legos.

ankurrsinghal avatar ankurrsinghal commented on August 20, 2024

Thanks, @kevmodrome for the suggestions, totally makes sense.

from svelte-legos.

ankurrsinghal avatar ankurrsinghal commented on August 20, 2024

Resolved, I think we should preserve the type actionin the actions, used them as suffix rather than prefix, now they read as for example, use:draggableAction.

from svelte-legos.

ankurrsinghal avatar ankurrsinghal commented on August 20, 2024

@kevmodrome let me know what you think.

from svelte-legos.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.