Giter Site home page Giter Site logo

comments don't get echoed about anonydog HOT 5 CLOSED

anonydog avatar anonydog commented on June 27, 2024
comments don't get echoed

from anonydog.

Comments (5)

thiagoarrais avatar thiagoarrais commented on June 27, 2024

Options:

  1. polling bot's PR issue comments

Docs: https://developer.github.com/v3/issues/comments/
Example: https://api.github.com/repos/thiagoarrais/personal-toolbox/issues/20/comments

  1. polling notifications api

Docs: https://developer.github.com/v3/activity/notifications/
Example: https://api.github.com/notifications

  1. expecting an integration webhook call for a comment on anonydog's relayed pull request

would be awesome. but it simply doesn't work :-)

anything else?

from anonydog.

thiagoarrais avatar thiagoarrais commented on June 27, 2024

current planed version:

  1. Poll https://api.github.com/notifications for any news on the various pull requests opened by the bot
  2. Upon getting a notification, go to it's subject/url (this should be the pull request API URL)
  3. Retrieve the pull request's comments (_links/comments) and diffline comments (_links/review_comments)
  4. Mirror each comment above to the original pull request (and store the original comment ids in some database to avoid re-mirroring).

Bonus points: mirror reviews. These are different from review comments (diffline comments). They can be found on the (experimental, not linked) URL https://api.github.com/repos/thiagoarrais/personal-toolbox/pulls/20/reviews

known drawback: this can't handle edited comments, since the notifications API does not expose those.

from anonydog.

thiagoarrais avatar thiagoarrais commented on June 27, 2024

Note to self: Normal comments are covered as of 694cba8. Need to work on review comments (diff comments).

from anonydog.

thiagoarrais avatar thiagoarrais commented on June 27, 2024

Review comments to-do list:

  • maintainer -> contributor (original)
  • maintainer -> contributor (reply)
  • contributor -> maintainer (original + reply)

from anonydog.

thiagoarrais avatar thiagoarrais commented on June 27, 2024

reopened until deployed to prod

from anonydog.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.