Comments (6)
Hi everyone,
Thank you for reporting this bug.
Yes, I indeed assumed that char are signed, but I can't remember why.
My mistake, standard doesn't specify if char is signed or unsigned by default.
I will fix that ASAP.
Best regards,
from z80emu.
Hello. I have verified that this is a problem on compiler that assume char is unsigned. I think that the OP meant to indicate that the xtensa compiler assumes char is unsigned. I compiled my project with char as unsigned by default and also ran into the same shift issues. Just wanted to confirm that this is indeed a problem.
from z80emu.
Ah yes.... I got confused while writing this issue - sorry for that. :-) But you are understanding me correctly. The xtensa compiler have unsigned chars whereas the code assumes that chars are signed.
But my crc's was slightly different from yours:
<rlca,rrca,rla,rra>........... OK
shf/rot (<ix,iy>+1)........... ERROR **** crc expected:710034cb found:cb127686
shf/rot <b,c,d,e,h,l,(hl),a>.. ERROR **** crc expected:a4255833 found:b5821b2b
<set,res> n,<bcdehl(hl)a>..... OK
from z80emu.
Hi again,
Ok, I reproduced the problem using gcc and "-funsigned-char" option.
Your CRCs are what I found, Mark's is CRC for zextest, and SmallRoomLabs' is CRC for zexall.
Long ago, I tried z80emu on an old SGI using MipsPro and I had a similar CRC error.
Don't remember well and didn't have time to investigate but I guess it was the same bug.
Working on fixing that, thanks again for your reports.
Best regards,
from z80emu.
Hi everyone,
Ok, I've fixed the code. And tested with "-funsigned-char".
Can you guys please give it a try, thank you?
If that's fine, I'll close this issue and update the README.txt.
You'll be credited and thanked, of course.
Best regards,
from z80emu.
Runs fine on myLX106 hardware now. You even found the RLC_INDIRECT_HL: which I had missed in my fixes. Strangely enough it seems like the zex'es doesn't cover that particular instruction fully enough to discover errors in the displacement.
Great job! Thanks for this.
from z80emu.
Related Issues (11)
- PC value in context HOT 1
- 2 instructions in one step HOT 3
- Inconsistent execution ld sp,ix HOT 3
- Where is SystemCall defined? HOT 1
- license HOT 7
- BIT n,(HL) and XY flags HOT 1
- Interrupt modes HOT 3
- Added feature HOT 3
- Mode2 Interrupts HOT 3
- halted state is not kept between emulation calls HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from z80emu.