Use external polyfills

[anselmh]

Use external polyfills

[TrySound]

closest is good for elements.matches.

[TrySound]

For "copy-lib" you may build bundle. For package managers build just core file and maybe getMatchedCSSRules polyfill. Other polyfills will be loaded as dependencies.

[TrySound]

Using closest will a little increase performance.

[anselmh]

Hi, thanks for the suggestions. I agree this could be done and have replaced the rAF polyfill with the one from npm.

I’ll see if I can make use of the closest polyfill and if it makes sense to use it here. Thanks for the hint.

For "copy-lib" you may build bundle. For package managers build just core file and maybe getMatchedCSSRules polyfill. Other polyfills will be loaded as dependencies.

Not sure what you mean here though? Can you explain this a bit more in detail perhaps?

[TrySound]

I meant cdn libs or copying directly in project folder.

[TrySound]

Also add rAF to bower, please.

[anselmh]

Thanks so far for your suggestions. It seems the polyfill is indeed a bit faster now again. I’ll see if I can make the dependency stuff a bit less messy.

[TrySound]

@anselmh Are you sure you need el.closest, not el.matches? closest polyfills both.

[TrySound]

And rAF is not devDep

[TrySound]

Closest is not devDependency too.

[TrySound]

Nice! I asked Jonathan Neal to publish closest on npm.

[TrySound]

@anselmh Closest added to npm
https://www.npmjs.com/package/element-closest

[TrySound]

@anselmh Are you sure you need el.closest instead of el.matches? closest polyfills both.

[anselmh]

Thanks. Fixed to use the npm version now. Therefore closing this issue for now.

@anselmh Are you sure you need el.closest instead of el.matches? closest polyfills both.

I tested this and it didn’t fail while speeding up the polyfill. That’s why. If there’s any issue with it it’s easy to roll back.

[TrySound]

@anselmh It works. But el.closest do some more work. It checks current or finds closest parent element with this selector. Better use el.matches.

[TrySound]

@anselmh Prefomance, heh))