Investigate why a pair of broken links were not picked up by CI

[samccann]

Investigate why a pair of broken links were not picked up by CI

[samccann]

Near as I can tell, rstcheck doesn't validate for a well-formed URI inside the hyperlink. The docutils spec for RST is here - https://docutils.sourceforge.io/docs/ref/rst/restructuredtext.html#embedded-uris-and-aliases
The links that are quietly broken (not found by CI), are as follows:
Control Node Requirements <:ref:control-node-requirements>_
So it has a title (Control Node Requirements) and a URI . So if nothing acutally checks the blablabla, the test passes.
That syntax is used for external links. The internal link syntax is :ref:Control Node Requirments <blablabla>
and if that were incorrect, rstcheck would flag it.
So a correct external link would be Control Node Requirements <http://docs.ansible.com/blablbla>_
aka it was a clever way of combining the two to seem like it would work, but didn't, and didn't fail tests either