Giter Site home page Giter Site logo

Comments (5)

rthallisey avatar rthallisey commented on September 2, 2024 1

The bind credential method changed after 3.7 to using a secret to store bind-creds. There's a published apb-base image with the tag release-1.0 you can use.

from ansible-asb-modules.

jwmatthews avatar jwmatthews commented on September 2, 2024

@djzager is taking a look to see if there a nice way we can make the change be backwards compatible so newer apb base can continue to work with the 3.7 released broker.

Expect to have a better idea tomorrow, will update issue with our thoughts.

As a fallback, the workaround is as @rthallisey suggests to use an older tag for apb-base, which is same path @jaymccon is using for the AWS APBs currently.

from ansible-asb-modules.

djzager avatar djzager commented on September 2, 2024

If we want to make new APBs compatible with older brokers we'll need to make a few changes.

  1. Add back some of the removed scripts from https://github.com/ansibleplaybookbundle/apb-base/pull/7/files . The entrypoint script will need to hold the logic on whether or not to exit. I suspect the best way to do this is on the POD_NAME and POD_NAMESPACE environment variables, if they have not been set, it must be an older broker and we need to wait for the broker to get the bind-credentials (this could cause unintended side-effects when the APB is docker run).
  2. Add logic to https://github.com/ansibleplaybookbundle/ansible-asb-modules/blob/master/library/asb_encode_binding.py#L71 to either write to a file or create a secret based on the existence of the POD_NAME|POD_NAMESPACE environment variables.

from ansible-asb-modules.

djzager avatar djzager commented on September 2, 2024

When we do (2) from above, we'll also need to update #11 to also update the last operation to handle an older broker also.

from ansible-asb-modules.

djzager avatar djzager commented on September 2, 2024

@jaymccon You are correct with the change that is causing issues for you. Currently, APB's with a runtime version of "2" are not supported for use with a release-1.0 broker. If you look at our ansible-service-broker deployment template you can see that we have locked down that branch to only use APBs with the release-1.0 tag for this reason.

As @rthallisey so quickly pointed out, the best solution is for APBs targeting a release-1.0 broker that you are building now should use the docker.io/ansibleplaybookbundle/apb-base:release-1.0 image. You can accomplish this by modifying the impacted APB's Dockerfile:

diff --git a/Dockerfile b/Dockerfile
--- a/Dockerfile
+++ b/Dockerfile
@@ -1,20 +1,21 @@
-FROM ansibleplaybookbundle/apb-base
+FROM ansibleplaybookbundle/apb-base:release-1.0

Please, let me know if you have any issues making use of the release-1.0 apb-base.

from ansible-asb-modules.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.