default Icon theme is missing in react and vue adaptors

[ant-design]

default Icon theme is missing in react and vue adaptors

[Torone]

@hongchanhk01 Can I know how did you fix the rollup configuratiuon to avoid this annoying issue? Thanks

[wzhudev]

@hongchanhk01

Hi. I am the author of the Angular adapter. You quoted a wrong line of the code. Actually, it's:

ant-design-icons/packages/icons-angular/lib/component/icon.service.ts

Line 86 in f8cac49

this._svgDefinitions.set(withSuffix(icon.name, icon.theme), icon);

For icons provided by ant design, theme property should always be specified.

So I guess the problem wasn't because of these codes?

[hongchanhk01]

@wendzhue

Indeed, I try to dig a little bit deeper seem the data from Icons not that correct. Not sure is it my build problem or something else

You can see there are some incorrect data at the first two item for the icons array

[wzhudev]

@hongchanhk01 I guess something is wrong with your building process. Actually, you just have to add raw svg files under svg dir and our script would do everything for you.

[hongchanhk01]

@wendzhue

I do think so. Thank you for your time and sorry for the noise.

It seem rollup include default es export for allIcons.

Will close the issues for now.

[hongchanhk01]

@wendzhue

Sorry for bother u again

https://github.com/ant-design/ant-design/blob/af8a025aebba01b28ff04fecff76d30117b6e068/components/icon/index.tsx#L3

ant-design/ant-design@c76a90b

May I know shouldn't the import here for ant design icon using just @ant-design/icons instead of the @ant-design/icons/lib/dist build.

Maybe this is why rollup does pick up the correct es modules ?

[htmlin]

@hongchanhk01 Can I know how did you fix the rollup configuratiuon to avoid this annoying issue? Thanks