Giter Site home page Giter Site logo

Comments (10)

carlocorradini avatar carlocorradini commented on May 29, 2024 1

Can we close this? @antfu

PS: My bad, I forgot to add Fix

from sponsorkit.

antfu avatar antfu commented on May 29, 2024

We could do a sorting, PR welcome :)

from sponsorkit.

carlocorradini avatar carlocorradini commented on May 29, 2024

Can we add a sort (or sortBy) to BadgePreset with default values. Examples:

sort: "ASC"

// or
sort: { name: "ASC" }

from sponsorkit.

antfu avatar antfu commented on May 29, 2024

We could always sort (by priority of sponsor amount -> sponsor date -> name alphabet). And maybe accepting a custom sort function if one wants to have full control (I imagine most of the cases there is no need to use it)

from sponsorkit.

carlocorradini avatar carlocorradini commented on May 29, 2024

Awesome. Agree on sponsor amount > sponsor date > name alphabet.
The sort function is the copy of the one from array implementation :)

from sponsorkit.

carlocorradini avatar carlocorradini commented on May 29, 2024

@antfu Always sorting includes all the providers?

from sponsorkit.

antfu avatar antfu commented on May 29, 2024

We could do that in the core instead of providers

from sponsorkit.

carlocorradini avatar carlocorradini commented on May 29, 2024

Here https://github.com/antfu/sponsorkit/blob/main/src/run.ts#L48 ?
Or ?

from sponsorkit.

antfu avatar antfu commented on May 29, 2024

Yeah I think so

from sponsorkit.

carlocorradini avatar carlocorradini commented on May 29, 2024

@MichalLytek See #43

from sponsorkit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.