Comments (12)
from ngx-auth-firebaseui.
Thanks for reporting @bailejl
I will inspect that bug bei writing some unit tests ... hopping to find the issue quickly!!!
from ngx-auth-firebaseui.
from ngx-auth-firebaseui.
@DannyHalm I will really appreciate a PR for that
from ngx-auth-firebaseui.
@bailejl what do you think about two checkboxes in the register card for both tosUrl and privacy policy url ? ... instead of the dialog ?
from ngx-auth-firebaseui.
@AnthonyNahas Yes, with links to tosUrl and privacy policy url. I think that would be perfect.
from ngx-auth-firebaseui.
from ngx-auth-firebaseui.
@bailejl I've just fixed this issue! You had 100% right! the signup middle to check privacy policy.. and so on.. was only linked with the guest button! Thanks for reporting again!
@bailejl @DannyHalm what do you think about the process and design related to this topic ?
Should I keep the checkboxes nested in a Material Dialog and the sign up buttons always enabled ? Or do you think that the checkboxes could be in a better place? below the material input ? the sign up and guest buttons disabled until the checkboxes are checked ?
from ngx-auth-firebaseui.
@bailejl @DannyHalm this has been fixed in v2.3.0! I would appreciate your feedback ❤️ Thank you
from ngx-auth-firebaseui.
I am only getting asked to approve if I choose guest on the demo. Not if I choose Google or Twitter.
Could it be it is the same problem again?
from ngx-auth-firebaseui.
It seems to still be a problem for a regular signup, with parameters set, no overlay shows or mandatory check required.
tosUrl="/legal/tos" privacyPolicyUrl="/legal/privacy"
Please investigate.
from ngx-auth-firebaseui.
Just look at the code of ngx-auth-firebaseui-register
component, and the functionality is totally missing.
I think a solution may be to adapt the ngx-auth-firebaseui
component to act as a register component.
from ngx-auth-firebaseui.
Related Issues (20)
- Compatibility with `firebase` v9 and `@angular/fire` v7 HOT 10
- Failed to compile entry-point ngx-auth-firebaseui (`es2015` as esm2015) due to compilation errors: HOT 3
- Gulp and Demo problems HOT 1
- Is this project being maintained? HOT 2
- Environments: config typo that breaks build HOT 1
- Value at position 22 in the NgModule.imports of NgxAuthFirebaseUIModule is not a reference HOT 9
- Building Schematics is broken after Angular 13 upgrade HOT 2
- Building ngx-auth-firebaseui is broken after Angular 13 upgrade HOT 1
- Update @angular-material-extensions/password-strength to ^10.0.0 HOT 3
- "Sign in" and "Register" tab buttons are not visible while using the Dark Theme HOT 1
- Install fails with @angular/[email protected] HOT 3
- Choose sign-in provider HOT 1
- angular 14 HOT 1
- Flex-layout dependency breaks install process HOT 3
- Add example of flat stacked UI login / register layout HOT 5
- Possible to customize login/signup UX: layout order, button text, etc
- Modular angularfire
- Support angular v15 HOT 6
- User avatar and profile image are not displaying correctly.
- Legality dialog should be localized
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ngx-auth-firebaseui.