Comments (9)
It would, thanks!
@parrt IIRC you have a script that automatically updates the license ? Would you be able to share it ?
from antlr5.
@parrt IIRC you have a script that automatically updates the license ? Would you be able to share it ?
I think it's possible to fix everything just using "Replace in files" functionality and regexes.
Regarding the packages, we should rename com.strumenta.antlrkotlin.runtime into org.antlr.v5.wasmruntime. Would this make sense?
If you mean files from https://github.com/antlr/antlr5/tree/dev/antlr-kotlin-runtime I think it doesn't make sense since currently they are unused (but they are kept to make it possible to implement other Kotlin targets later). If you mean files from https://github.com/antlr/antlr5/tree/dev/runtime/Kotlin/src I think it's incorrect to use org.antlr.v5.wasmruntime
package name because they are not wasm-specific.
from antlr5.
https://github.com/antlr/antlr5/tree/dev/antlr-kotlin-runtime
Regarding this directory name. It looks confused because actually it's kind of "remnants" and it makes sense to rename the directory to something like antlr-kotlin-runtime-remnants
and add info to Readme that they should be eliminated in the future.
from antlr5.
https://github.com/antlr/antlr5/tree/dev/antlr-kotlin-runtime
Regarding this directory name. It looks confused because actually it's kind of "remnants" and it makes sense to rename the directory to something like
antlr-kotlin-runtime-remnants
and add info to Readme that they should be eliminated in the future.
Agreed, please proceed
from antlr5.
I'll have to dig that script up!
from antlr5.
@ftomasseti am I correct thinking this is is fixed by #19 ?
from antlr5.
@ericvergnaud #19 updates the copyright, I still need to fix the package names. For that another PR is coming
from antlr5.
@ftomassetti can we close this ?
from antlr5.
Yes, sorry I forgot to close it
from antlr5.
Related Issues (20)
- Squashed errors for mutually left-recursive rules with incorrect positions HOT 6
- Integrate Kotlin runtime HOT 38
- Trim non-critical runtimes HOT 5
- Rename references to ANTLR v4 in references to ANTLR v5 HOT 2
- Renaming Modes.DEFAULT_MODE to Modes.DEFAULT in the Kotlin runtime and target HOT 1
- Rename grammars suffix from g4 to g5 HOT 3
- How to run test locally in a reproducible way? HOT 15
- Update docs for v5
- Remove reference to Python in GitHub Actions workflow
- Rename Antlr4MojoTest in Antlr5TMojoTest
- Help with kotlin-js HOT 17
- Possible improvements for tool builders HOT 10
- Design - Compile the runtime Lexer to WebAssembly HOT 16
- Migrate epsilon optimization related changes to Kotlin HOT 3
- Normalize target and folder capitalization
- Rename java runtime package to org.antlr.v5.runtime.java
- Migrate the build to Gradle HOT 4
- Change nullables to non-nullables in core runtime HOT 1
- Generate UnicodeData using Gradle HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from antlr5.