Giter Site home page Giter Site logo

Comments (9)

ericvergnaud avatar ericvergnaud commented on July 28, 2024

It would, thanks!
@parrt IIRC you have a script that automatically updates the license ? Would you be able to share it ?

from antlr5.

KvanTTT avatar KvanTTT commented on July 28, 2024

@parrt IIRC you have a script that automatically updates the license ? Would you be able to share it ?

I think it's possible to fix everything just using "Replace in files" functionality and regexes.

Regarding the packages, we should rename com.strumenta.antlrkotlin.runtime into org.antlr.v5.wasmruntime. Would this make sense?

If you mean files from https://github.com/antlr/antlr5/tree/dev/antlr-kotlin-runtime I think it doesn't make sense since currently they are unused (but they are kept to make it possible to implement other Kotlin targets later). If you mean files from https://github.com/antlr/antlr5/tree/dev/runtime/Kotlin/src I think it's incorrect to use org.antlr.v5.wasmruntime package name because they are not wasm-specific.

from antlr5.

KvanTTT avatar KvanTTT commented on July 28, 2024

https://github.com/antlr/antlr5/tree/dev/antlr-kotlin-runtime

Regarding this directory name. It looks confused because actually it's kind of "remnants" and it makes sense to rename the directory to something like antlr-kotlin-runtime-remnants and add info to Readme that they should be eliminated in the future.

from antlr5.

ericvergnaud avatar ericvergnaud commented on July 28, 2024

https://github.com/antlr/antlr5/tree/dev/antlr-kotlin-runtime

Regarding this directory name. It looks confused because actually it's kind of "remnants" and it makes sense to rename the directory to something like antlr-kotlin-runtime-remnants and add info to Readme that they should be eliminated in the future.

Agreed, please proceed

from antlr5.

parrt avatar parrt commented on July 28, 2024

I'll have to dig that script up!

from antlr5.

ericvergnaud avatar ericvergnaud commented on July 28, 2024

@ftomasseti am I correct thinking this is is fixed by #19 ?

from antlr5.

ftomassetti avatar ftomassetti commented on July 28, 2024

@ericvergnaud #19 updates the copyright, I still need to fix the package names. For that another PR is coming

from antlr5.

ericvergnaud avatar ericvergnaud commented on July 28, 2024

@ftomassetti can we close this ?

from antlr5.

ftomassetti avatar ftomassetti commented on July 28, 2024

Yes, sorry I forgot to close it

from antlr5.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.