Comments (8)
Thanks for catching this and fixing it!
This is published as v4.4.0
from panzoom.
Using Chrome 65.0.3325
from panzoom.
Heh. I just found this comment in the beginning of function _addWheelListener
:
// TODO: in theory this anonymous function may result in incorrect
// unsubscription in some browsers. But in practice, I don't think we should
// worry too much about it (those browsers are on the way out)
from panzoom.
After debugging the issue in wheel, I have found that the elem
is not the same on addEventListener
and removeEventListener
.
I'm using vue.js, and have to investigate if it's because vue.js is changing the DOM element or if it's in panzoom. What is strange if it's vue.js, is that the other event handlers seems to be removed just fine.
from panzoom.
Found it! wheel is listening to owner
but trying to remove the wheel listener on domElement
.
from panzoom.
For everyone else with this issue, I have a published a release candidate here: https://www.npmjs.com/package/@dotnetcarpenter/panzoom
from panzoom.
@anvaka nice that you added tests! I was wondering how to test this.
from panzoom.
you can run npm test
in the project's folder
from panzoom.
Related Issues (20)
- Two finger pan is already implemented? HOT 3
- Why is there a black border when I press the keyboard HOT 4
- Artifacts appearing when pan/zooming with audio element HOT 1
- Is there a way to resume paused panzoom while holding mousedown? HOT 1
- Pause/resume the panzoom not working?
- Speed for SmoothZoom
- How to track zoom-in and zoom-out when zooming image in carousel
- Pan restrict only to image view HOT 1
- Bounds doesn't work when you rotate the parent div.
- Multiple panzoom?
- Brake/destroy pan animation
- Disable pan on zoom/scale == 1?
- Pan is too sensitive
- Disable zoom on ios and android? HOT 1
- Zoom and Pan iframe array HOT 1
- Images drifting off screen
- Remove and restore transform styles
- zoomAbs, smoothZoom, moveTo etc weird effects HOT 1
- swipe left / right to change "page"
- onDoubleClick zoom in zoom out
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from panzoom.