Giter Site home page Giter Site logo

Comments (7)

danmt avatar danmt commented on August 28, 2024 1

I believe the issue is related to parcel, more specifically to this issue parcel#1747. Apparently, there's some weirdness about the global variables when using this bundler. Will close the issue for now since I was able to workaround it by using webpack instead.

from wallet-adapter.

jordaaash avatar jordaaash commented on August 28, 2024 1

Thanks for following up on this. Good to know about the issue with Parcel. There's an open PR that might help: #32

The additional checks for typeof window != 'undefined' to fix server side rendering issues might also fix the issue with Parcel.

from wallet-adapter.

jordaaash avatar jordaaash commented on August 28, 2024

Thanks for the reproduction. So I understand clearly, is this related to the Sollet browser extension, or the sollet.io web wallet?

from wallet-adapter.

danmt avatar danmt commented on August 28, 2024

Web wallet. I misread the other issue, I think this is a different thing.

Let me know if I can help somehow

from wallet-adapter.

jordaaash avatar jordaaash commented on August 28, 2024

I attempted to replicate the issue after fixing issues building the project -- danmt/solana-wallet-adapter-sollet-repro#1 (comment)

I wasn't able to. Please let me know if you still experience it with that PR.

from wallet-adapter.

danmt avatar danmt commented on August 28, 2024

I replied in the PR but for easier follow up for others facing this issue I copy-pasted it here.

After merging I'm facing the same problem.

I tested using [email protected] and [email protected].

Steps to reproduce:

  • Clone the repo
  • Install dependencies (I tried with Yarn and NPM)
  • Run npm run serve
  • Click Connect Sollet button
  • Proceed to connect

The weird things I noticed so far:

  • As soon as sollet's window opens the app console throws a WindowClosedError.
  • After authenticating in Sollet, the new window redirects me to the wallet instead of authorizing my app.
  • Even though the .ready() getter from the Sollet adapter is hard-coded, I'd expect a "sollet ready" event to be fired which isn't the case.

BTW - I tried this using a fresh NPM install, fresh yarn install and yarn install --frozen-lockfile none of em worked for me.

from wallet-adapter.

danmt avatar danmt commented on August 28, 2024

I think the problem relates to the fallbacks (crypto, path, os and so on) or polyfills.

from wallet-adapter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.