Giter Site home page Giter Site logo

Comments (10)

moonming avatar moonming commented on May 17, 2024

is https://github.com/apache/apisix-docker good for you?

from apisix-docker.

gy09535 avatar gy09535 commented on May 17, 2024

I think it can not build code from local repos

is https://github.com/apache/apisix-docker good for you?

I think it can not build images from our private repository for secondary develop. If I change some code for our different logical, https://github.com/apache/apisix-docker can not work for me.

from apisix-docker.

juzhiyuan avatar juzhiyuan commented on May 17, 2024

Do we have a final discussion result here?

from apisix-docker.

moonming avatar moonming commented on May 17, 2024

@gy09535 Which part of the code did you modify? I'm not sure whether exposing the code directory will solve this problem?

from apisix-docker.

gy09535 avatar gy09535 commented on May 17, 2024

@gy09535 Which part of the code did you modify? I'm not sure whether exposing the code directory will solve this problem?

I want build the code with source code ,but I have change some code such as self define plugins. The https://github.com/apache/apisix-docker/blob/master/alpine/Dockerfile is build the code from github , but our code in our private repository . Now when the apache apisix has new release I merge it in our self repository and build a new image for our business. I think some company maybe has the same problem? So I think maybe we should add the Docker file in the source code and build with source code other then github code.

from apisix-docker.

moonming avatar moonming commented on May 17, 2024

@gy09535 Got it.
The current dockerfile does not consider the situation of building from local source code. Welcome to PR to add, I transferred this issue to the apisix-docker project

from apisix-docker.

gy09535 avatar gy09535 commented on May 17, 2024

@gy09535 Got it.
The current dockerfile does not consider the situation of building from local source code. Welcome to PR to add, I transferred this issue to the apisix-docker project

I add the Dockerfile in apisix project, I think if we build it in source code ,we should add it in source code.

from apisix-docker.

gxthrj avatar gxthrj commented on May 17, 2024

I think this feat is a better way, and we do not need to maintain multiple versions between different basic (os) images.

from apisix-docker.

gxthrj avatar gxthrj commented on May 17, 2024

it is related to apache/apisix#2783

from apisix-docker.

github-actions avatar github-actions commented on May 17, 2024

This issue has been marked as stale due to 30 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, please simply write any comment. Even if closed, you can still revive the issue at any time or discuss it on the [email protected] list. Thank you for your contributions.

from apisix-docker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.