Giter Site home page Giter Site logo

Comments (3)

raphinesse avatar raphinesse commented on June 18, 2024 1

Thanks for your feedback @brodybits !

I think it would be good to get the Cordova tooling API documented. Should this be raised as a separate task?

Yes, the tooling libs definitely need better documentation. Prefereable in their respective README.
I already added that point to our release planning document, so I think we are fine for now.

If we change the public cordovaCreate function API on cordova-create I would favor allowing the caller to inject the fetch function for smoother mocking. (No need for cordova-lib to export this option, I think.)

I'm not too fond of polluting the public interface for testing only. Jasmine spies and rewire work pretty well for me, given the test subject has a reasonable structure.

If we need DI for real-world use cases, I'm open to it. I would probably move it to a separate issue though, as it is an additional feature.

from cordova-discuss.

brodybits avatar brodybits commented on June 18, 2024

I do not see if the public cordovaCreate function API, which seems to be exported by both cordova-create and cordova-lib, was documented anywhere other than in a README. From NPM I see very few direct dependents of cordova-create, more dependents of cordova-lib including some gulp plugins (which seem to be a bit old).

I think it would be good to get the Cordova tooling API documented. Should this be raised as a separate task?

If we change the public cordovaCreate function API on cordova-create I would favor allowing the caller to inject the fetch function for smoother mocking. (No need for cordova-lib to export this option, I think.)

from cordova-discuss.

raphinesse avatar raphinesse commented on June 18, 2024

This issue was moved to apache/cordova-create#21

from cordova-discuss.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.