Giter Site home page Giter Site logo

Comments (1)

breautek avatar breautek commented on June 4, 2024

Most of our "settings" would belong in config.xml but given this is more of a developer/build config, rather than an app config, an environment variable might be the way to go...

If we do use an environment variable, I think it's important to make a distinct variable per platform, like your suggested CORDOVA_DEFAULT_IOS_TARGET.

What you could do is maybe prepare a small document or some blurb of text describing what you plan to implement behaviour wise and subscribe/write to our Dev Mailing List with your intent. This will put more visibility among cordova contributors as GH notifications can be a bit noisy. (Just know the mailing list is for discussions regarding development & management of the cordova project only) It will probably be important to limit that scope to behaviour rather than code (code review is much easier on a PR) but what I'd probably recommend is something like:

  1. If --target is present, then set target to --target value.
  2. Else if CORDOVA_DEFAULT_IOS_TARGET exists, then set target to CORDOVA_DEFAULT_IOS_TARGET value
  3. else; fallback to getDefaultSim() (or whatever the method is called)

I'm not very familiar with the part of code that handles the --target... But if the code is primarily in the platform (e.g. cordova-ios, then it's safe to hard-code CORDOVA_DEFAULT_IOS_TARGET environment variable lookup), otherwise you might have to incorporate the flow of choosing CORDOVA_DEFAULT_IOS_TARGET over some other platform target.

Give 48-72 hours to let people object to your plans. If there are any objections the mailing thread is Apache official way to resolve those kinds of disputes. And if there is an agreement (either explicitly or lazily by silence) then a PR could be created. This might save time building a PR that won't get accepted without drastic changes.

from cordova-ios.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.