iOS CDVWKInAppBrowser evaluateJavascript method randomly gets blocked on iOS 12

[apache]

iOS CDVWKInAppBrowser evaluateJavascript method randomly gets blocked on iOS 12

[dpa99c]

The PR changes look good to me:
as @jonathanli2 points out, the synchronous return value is never used in CDVWKInAppbrowser since the result is returned asynchronously via the postMessage API.
The loop was just a hangover from the UIWebView implementation that I forgot to take out.

[jonathanli2]

Add the comment from
https://stackoverflow.com/questions/26778955/wkwebview-evaluate-javascript-return-value

"This solution IS NOT WORKING anymore. The callback now called from the main Thread and if you lock the main thread in the while loop (like in this solution), the callback handler will be never called. evaluateJavaScript waits for main thread released, but it never happens because it locked in the loop. – Mike Keskinov Sep 4 at 0:21"

[jonathanli2]

As the return value from CDVWKInAppbrowser's evaluateJavascript method is actually never used, it may well just changes the function signature to
- (void)evaluateJavaScript:(NSString *)script
and so we can remove the while loop which blocks the method from returning.

Thanks
Jonathan

[jonathanli2]

A change has been made at the pull request
#341

[janpio]

Could you take a look please @dpa99c?

[jonathanli2]

Any update for this pull request?

[jonathanli2]

The pull request has been merged, and the issue is closed.

Thanks
Jonathan

[janpio]

(FYI: If you use closes #340 in the text of a PR, it will automatically close the issue when the PR is merged. Can use that for your next PR.)