Comments (8)
An interesting thing to decide is if VS15 should still be supported or if we drop everything but VS2017. Since VS17 Microsoft includes a vswhere
executable at a known location that can be used to find the MSBuild
location, which would make all the VS/MSBuild detection logic we have (reading registry, trying paths, bla) obsolete. This is our no 1 source of problems right now.
Also, do we maybe also drop Windows Phone 10? It is EOL and unsupported by Microsoft as far as I know.
from cordova-windows.
Sounds good. If I could invest the time to tackle this, I would first get rid of everything obvious connected to Win8.1 and Phone, then see what is left and how it could be rewritten in a simplified manner - especially the MSBuild selection is absolute crap right now.
from cordova-windows.
I just want to point out that vswhere
was first bundled with VS2017 version 15.2
. It didn't actually come with the initial release of VS2017 version 15.0.
A recent setup of a Windows VM with VS2017 did not have vswhere
. It was either a bugged install or an older version such as 15.0 was installed. After I ran an update, with the VS installer, vswhere
was installed.
Could possibly bundle vswhere
within our platform as well, if there is no issues against Apache with bundled binaries. https://github.com/Microsoft/vswhere/releases
from cordova-windows.
Makes sense, but is a lot of work as removing the Win8.1 parts destroys quite a lot of the code and makes it even less readable. #264 stalled because of that.
from cordova-windows.
Thanks @janpio. I would like to take another look at this as I think we do not want to support 8.1 any longer than absolutely needed.
I am interested in cleaning up Windows 10 support as it is still needed by a major client.
from cordova-windows.
I just went through the changes of #264 and I think most of them still make sense - it becomes clear which parameters can be removed, what warnings should be added, and quite a lot of the code and tests that can be removed. What the PR didn't cover was the cleanup phase and a sane MSBuild detection mechanism. But otherwise I am pretty happy how good it holds up, could definitely be a good idea base for starting a new branch to tackle this properly again.
from cordova-windows.
+1 on just including it (if possible) - would make stuff so much more stable.
from cordova-windows.
We are archiving this repository following Apache Cordova's Deprecation Policy. We will not continue to work on this repository. Therefore all issues and pull requests are being closed. Thanks for your contribution.
from cordova-windows.
Related Issues (20)
- JavaScript UWP development from VS 2019 not supported HOT 1
- JavaScript UWP development from Visual Studio 2019 not supported HOT 1
- Can't cordova build or run platform windows with Visual Studio 2017 HOT 3
- use @cordova/eslint-config HOT 1
- META: start major release 8.0.0 with some breaking changes HOT 1
- Can we use target minimum windows SDK version 10.0.16299.0 HOT 1
- Error: WebGL not supported HOT 2
- Windows: uap capability included when building for 8.1 HOT 1
- Using Chrome-based webview as rendering backend for Cordova for Windows instead of EdgeHTML HOT 2
- comma as decimal separator on ```<input type="number"> ``` HOT 1
- window.alert , prompt, confirm not working, please help me it is an emergency. Please please help me urgently.ππ»ππ»ππ»ππ» HOT 1
- The following navigation rule had an invalid URI scheme and will be ignored: "*". HOT 1
- Microsoft Surface hybrid touch events HOT 1
- Absolute (root relative) paths do not resolve to www folder, instead point to C:\... HOT 3
- Cordova installation problem HOT 2
- Running HelloWorld throws an error HOT 2
- package.windows10.appxmanifest does not set the correct descriptions as in config.xml HOT 1
- instructions from https://cordova.apache.org for platform Windows erroneous HOT 1
- The processor architecture of your project 'arm' doesnβt match the processor architecture 'x86' of the referenced project 'SQLite3.UWP'. HOT 1
- shelljs 0.5.3 is vulnerable HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cordova-windows.