Comments (8)
The api-test
and e2e
conducts end-to-end testing from the back end and the front end respectively. We shouldn't invade the original code too much just because of the tests. Code optimization and testing are two separate issues.
So I'm -1 on this. cc @ruanwenjun
from dolphinscheduler.
The
api-test
ande2e
conducts end-to-end testing from the back end and the front end respectively. We shouldn't invade the original code too much just because of the tests. Code optimization and testing are two separate issues.So I'm -1 on this. cc @ruanwenjun
just like #15861
In fact we do not invade the original code too much and just keep WorkerTaskExecutor as a runnable, and move dependencies using observer/lister pattern like quartz.
you will realize that remote-logging/alert code can be move to listener part, which will not be executed when we directly runningWorkerTaskExecutor directly and easy to extend if we wants to add more listener towards task life-cycle.
I think the cost is very less and the return is large.
from dolphinscheduler.
This PR #15861 is mostly bugfix, while adding tests for cluster deployment. Even without this test, the code remains the same
from dolphinscheduler.
This PR ##15861 is mostly bugfix, while adding tests for cluster deployment. Even without this test, the code remains the same
sorry to confuse, the key point of the PR is to add registry related integration to improve robustness.
from dolphinscheduler.
sorry to confuse, the key point of the PR is to add registry related integration to improve robustness.
Based on the modification of #16233, I don't think this makes any sense in terms of code optimization or unit testing.
from dolphinscheduler.
sorry to confuse, the key point of the PR is to add registry related integration to improve robustness.
https://github.com/apache/dolphinscheduler/pull/15861/files#diff-4221e7060cb5692b5e8656f8f092468895f4bc8804397e8de7cb4cfdf8d95024Based on the modification of #16233, I don't think this makes any sense in terms of code optimization or unit testing.
This is only first stage.
first stage we only kept tenantconfig instead of workerconfig, which will make it easyier to build only use enable/disable properties in it.
second stage I will move out remote-logging/alert part using observer/listener pattern is another PR.
if you not bother, we can sync offline if you are not mind.
from dolphinscheduler.
Now api-test has directly run api-test towards spring multiple embedded service, include but not limit to api/master/worker.
To improve our task robustness and make it easy to integration test
According to your description, you want to optimize api-test
to make it more robust and convenient. But I didn't see anything relevant in either of the two stages you described, or in PR.
from dolphinscheduler.
Now api-test has directly run api-test towards spring multiple embedded service, include but not limit to api/master/worker.
To improve our task robustness and make it easy to integration testAccording to your description, you want to optimize
api-test
to make it more robust and convenient. But I didn't see anything relevant in either of the two stages you described, or in PR.
Thanks @SbloodyS and @ruanwenjun for guiding offline.
It seems we should keep api-test
standard to make each flow aligned with user's experience.
from dolphinscheduler.
Related Issues (20)
- [Doc][Installation] Polish installation docs
- [Bug] [Standalone Server] Showing Connection Spring Boot-MySql : Public Key Retrieval is not allowed while trying to init the database HOT 6
- [Doc][NOTICE] Correct year in NOTICE file
- [Improvement][API] Add workflow and scheduled status change operators for auditing
- [Bug] [dolphinscheduler-task-Shell] Serial wait, variable lost
- [Question] [Tenant Creation] Not automatically creating new tenant locally HOT 3
- [Bug] Fix zk registry reconnect after session timeout cannot write heartbeat to zk
- [Improvement] Cannot stop serial wait workflow instance
- [Bug] [UI] Offline workflow error
- [Bug] [dolphinscheduler-storage-hdfs] When you create a new task, the resource file cannot be displayed hierarchically
- [Bug] [dolphinscheduler-task-Shell] cluster mode error NoSuchFileException: /mnt/dolphinscheduler/exec/process/.../htdws.jar
- [Improvement][Helm] Support for updateStrategy
- [Improvement] tenant supports users of other databases like ldap HOT 5
- py4j.protocol.Py4JJavaError: An error occurred while calling t.createUser
- [Question] [Master] Complement process instances executed in parallel influence each other HOT 3
- The parameter data format cannot be changed when assembling SQL query parameters. When parameter variables are added to the create table name and used, the " signs" on both sides of the variables cannot be removed. HOT 2
- [Bug] [Resource] Failed to upload file HOT 5
- [Bug] JdbcRegistry might get duplicate result in getChildren
- I custom the WorkerHeartBeat send every 100 seconds,but the zookeeper session didn't expired? HOT 2
- [Bug] [dao] Incorrect parameter name 'processLineages' in batchInsert method HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dolphinscheduler.