Giter Site home page Giter Site logo

Comments (8)

SbloodyS avatar SbloodyS commented on August 16, 2024

The api-test and e2e conducts end-to-end testing from the back end and the front end respectively. We shouldn't invade the original code too much just because of the tests. Code optimization and testing are two separate issues.

So I'm -1 on this. cc @ruanwenjun

from dolphinscheduler.

pegasas avatar pegasas commented on August 16, 2024

The api-test and e2e conducts end-to-end testing from the back end and the front end respectively. We shouldn't invade the original code too much just because of the tests. Code optimization and testing are two separate issues.

So I'm -1 on this. cc @ruanwenjun

just like #15861
In fact we do not invade the original code too much and just keep WorkerTaskExecutor as a runnable, and move dependencies using observer/lister pattern like quartz.

image

you will realize that remote-logging/alert code can be move to listener part, which will not be executed when we directly runningWorkerTaskExecutor directly and easy to extend if we wants to add more listener towards task life-cycle.

I think the cost is very less and the return is large.

from dolphinscheduler.

SbloodyS avatar SbloodyS commented on August 16, 2024

This PR #15861 is mostly bugfix, while adding tests for cluster deployment. Even without this test, the code remains the same

from dolphinscheduler.

pegasas avatar pegasas commented on August 16, 2024

This PR ##15861 is mostly bugfix, while adding tests for cluster deployment. Even without this test, the code remains the same

sorry to confuse, the key point of the PR is to add registry related integration to improve robustness.

https://github.com/apache/dolphinscheduler/pull/15861/files#diff-4221e7060cb5692b5e8656f8f092468895f4bc8804397e8de7cb4cfdf8d95024

from dolphinscheduler.

SbloodyS avatar SbloodyS commented on August 16, 2024

sorry to confuse, the key point of the PR is to add registry related integration to improve robustness.

https://github.com/apache/dolphinscheduler/pull/15861/files#diff-4221e7060cb5692b5e8656f8f092468895f4bc8804397e8de7cb4cfdf8d95024

Based on the modification of #16233, I don't think this makes any sense in terms of code optimization or unit testing.

from dolphinscheduler.

pegasas avatar pegasas commented on August 16, 2024

sorry to confuse, the key point of the PR is to add registry related integration to improve robustness.
https://github.com/apache/dolphinscheduler/pull/15861/files#diff-4221e7060cb5692b5e8656f8f092468895f4bc8804397e8de7cb4cfdf8d95024

Based on the modification of #16233, I don't think this makes any sense in terms of code optimization or unit testing.

This is only first stage.

first stage we only kept tenantconfig instead of workerconfig, which will make it easyier to build only use enable/disable properties in it.
second stage I will move out remote-logging/alert part using observer/listener pattern is another PR.

if you not bother, we can sync offline if you are not mind.

from dolphinscheduler.

SbloodyS avatar SbloodyS commented on August 16, 2024

Now api-test has directly run api-test towards spring multiple embedded service, include but not limit to api/master/worker.
To improve our task robustness and make it easy to integration test

According to your description, you want to optimize api-test to make it more robust and convenient. But I didn't see anything relevant in either of the two stages you described, or in PR.

from dolphinscheduler.

pegasas avatar pegasas commented on August 16, 2024

Now api-test has directly run api-test towards spring multiple embedded service, include but not limit to api/master/worker.
To improve our task robustness and make it easy to integration test

According to your description, you want to optimize api-test to make it more robust and convenient. But I didn't see anything relevant in either of the two stages you described, or in PR.

Thanks @SbloodyS and @ruanwenjun for guiding offline.
It seems we should keep api-test standard to make each flow aligned with user's experience.

from dolphinscheduler.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.