Giter Site home page Giter Site logo

Comments (8)

klesh avatar klesh commented on June 19, 2024 1

@IronCore864 @JorgeGar
The localtime volume makes sense for docker-compose, I believe the helm chart localtime volume was derived from it.
So, yes, we could remove localtime volume if it is not the best practice for helm chart which I'm not an expert by any means, I would concur with whatever you think is the best.😊

from incubator-devlake-helm-chart.

klesh avatar klesh commented on June 19, 2024

Calling experts @JorgeGar @IronCore864

from incubator-devlake-helm-chart.

JorgeGar avatar JorgeGar commented on June 19, 2024

I also had issues with the localtime being a hostPath but on the permission side. Kubernetes recommend avoiding the hostPath unless they are completely required: https://kubernetes.io/docs/concepts/storage/volumes/#hostpath.
@BrookeKatalon could you create a PR with the fix?

from incubator-devlake-helm-chart.

BrookeKatalon avatar BrookeKatalon commented on June 19, 2024

I tried to push my local issues/134 with the workaround/fix but I get an error:
[issues/134 44b9c30] comment out volume mappings for TZ symlinks so AWS EKS doesnt fail
3 files changed, 75 insertions(+), 76 deletions(-)
❯ git push
ERROR: Permission to apache/incubator-devlake-helm-chart.git denied to BrookeKatalon.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

from incubator-devlake-helm-chart.

JorgeGar avatar JorgeGar commented on June 19, 2024

Are you trying to push from the very same repo?
If so, that's the issue.
The process should be to fork the repo, and then from the forked one, you create the branch, work on it and push it to your branch. Later you can create the PR from the forked repo branch to the main repo. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork.

Having said that... If you're already doing, then I don't know what's going on 😄

from incubator-devlake-helm-chart.

BrookeKatalon avatar BrookeKatalon commented on June 19, 2024

D'oh! You can tell I work on internal repos only. Forked and PR created

from incubator-devlake-helm-chart.

IronCore864 avatar IronCore864 commented on June 19, 2024

Is it possible to remove the localtime volume mount?

If not, is it possible to create a configmap containing the value and mount the configmap instead of a hostpath?
@klesh

from incubator-devlake-helm-chart.

JorgeGar avatar JorgeGar commented on June 19, 2024

If we could pass the localtime as an env variable or configmap as @IronCore864 mentioned, that would be the best option.

from incubator-devlake-helm-chart.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.