Comments (9)
I would like to pick this task ✋
from incubator-eventmesh.
Ohhh, that doesn't need to be changed to switch.
from incubator-eventmesh.
And I think this should be simple enough so I would want to work on one more task if you would be kind enough to recommend one for me :)
from incubator-eventmesh.
For below line,
https://github.com/apache/eventmesh/blob/master/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/grpc/push/WebhookPushRequest.java#L190
I am getting the sonar validation error that there should be more conditions to use switch case and it is better to use if statement since we only have one condition.
Let me know if you still want me to change it to switch case.
from incubator-eventmesh.
@kartiktayal Hello and welcome to the eventmesh community, welcome contributions.
from incubator-eventmesh.
Hi, where is the modification? I did not understand, line 190?
from incubator-eventmesh.
Hi, where is the modification? I did not understand, line 190?
For line 190, since there is only one condition, I was getting a sonar warning that it is better to use if else statement instead of switch case
from incubator-eventmesh.
Ohhh, that doesn't need to be changed to switch.
I am open for another task as well if this is done.
from incubator-eventmesh.
You are very welcome to contribute to eventmesh!
from incubator-eventmesh.
Related Issues (20)
- [Doc] Rewrite quick start and add operator deployment steps.
- [Bug] WatchFileManagerTest unit test failed
- [Enhancement] Add shutdown for nacosConfigService
- [Feature] Migrate eventmesh-admin module to eventmesh-dashboard repo
- [Enhancement] DISCLAIMER and NOTICE is outdated
- [Bug] Enable Dependabot on the repository HOT 11
- [Enhancement] Use gradle-build-action for caching and build scan link promotion HOT 1
- [Bug] Can not obtain metadata when nacos enable authentication
- [Doc] Update issue template and remove deprecated connector docs
- [Enhancement] Deploy eventmesh-operator to a k8s cluster
- [Feature] Integrated deployment of EventMesh-Operator and rocketmq in a k8s cluster
- [Feature] Integrated deployment of Eventmesh-Operator with nacos in a k8s cluster
- [Enhancement] Optimize the HttpRequestProcessor can obtain executor
- [Enhancement] Substitute `e.printStackTrace()` with `log.error()` HOT 11
- [Enhancement] Use the `static final` modifier to decorate `Logger` HOT 6
- [Enhancement] Optimize the SubscriptionManager thread safety
- [Bug] CodeQL task failed due to enabled build cache HOT 4
- [Enhancement] Integrate Runtime admin endpoints with Netty server HOT 3
- [Bug] CI `Build C` task compile error: `[makefile:81: librmb.a] Error 9`
- [Enhancement] Integrate Runtime admin endpoints with Netty server phase 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from incubator-eventmesh.