Giter Site home page Giter Site logo

Comments (9)

kartiktayal avatar kartiktayal commented on July 19, 2024 1

I would like to pick this task ✋

from incubator-eventmesh.

Alonexc avatar Alonexc commented on July 19, 2024 1

Ohhh, that doesn't need to be changed to switch.

from incubator-eventmesh.

kartiktayal avatar kartiktayal commented on July 19, 2024

And I think this should be simple enough so I would want to work on one more task if you would be kind enough to recommend one for me :)

from incubator-eventmesh.

kartiktayal avatar kartiktayal commented on July 19, 2024

For below line,
https://github.com/apache/eventmesh/blob/master/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/grpc/push/WebhookPushRequest.java#L190
I am getting the sonar validation error that there should be more conditions to use switch case and it is better to use if statement since we only have one condition.
Let me know if you still want me to change it to switch case.

from incubator-eventmesh.

Alonexc avatar Alonexc commented on July 19, 2024

@kartiktayal Hello and welcome to the eventmesh community, welcome contributions.

from incubator-eventmesh.

Alonexc avatar Alonexc commented on July 19, 2024

Hi, where is the modification? I did not understand, line 190?

from incubator-eventmesh.

kartiktayal avatar kartiktayal commented on July 19, 2024

Hi, where is the modification? I did not understand, line 190?

For line 190, since there is only one condition, I was getting a sonar warning that it is better to use if else statement instead of switch case

from incubator-eventmesh.

kartiktayal avatar kartiktayal commented on July 19, 2024

Ohhh, that doesn't need to be changed to switch.

I am open for another task as well if this is done.

from incubator-eventmesh.

Alonexc avatar Alonexc commented on July 19, 2024

You are very welcome to contribute to eventmesh!

from incubator-eventmesh.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.