[Java|Go] Check string is ascii before using meta string encoding

[chaokunyang]

[Java|Go] Check string is ascii before using meta string encoding

[jasonmokk]

@LiangliangSui Thanks for bringing that up, can I submit another PR to correct that/add unit tests? I also think it would be optimal to have the ASCII check early and just directly return a UTF-8 encoded MetaString.

[jasonmokk]

Hi @chaokunyang I'd like to contribute to Apache Fury, can you please assign this issue to me?

[LiangliangSui]

Great! thanks for the willingness to contribute to Fury.

[LiangliangSui]

// org/apache/fury/meta/MetaStringEncoder.java
public MetaString encode(String input) {
  if (input.isEmpty()) {
    return new MetaString(input, Encoding.UTF_8, specialChar1, specialChar2, new byte[0]);
  }
  Encoding encoding = computeEncoding(input);
  return encode(input, encoding);
}

Could we judge here whether the input is all ASCII encoded? If not, just return UTF-8 encoded MetaString directly, so that we can save time on computeEncoding and encode.

WDYT @chaokunyang

[LiangliangSui]

In addition, we also need to add unit tests to cover this issue

[LiangliangSui]

can I submit another PR to correct that/add unit tests?

Sure, that is great!