Comments (3)
I'd like to have a look concerning braces, but I'm not sure if I beat a dead horse. If someone is successful with a more common tool (as discussed on mailing list) all the work would become obsolete suddenly.
from incubator-nuttx.
@johannes-nivus It is important that we document shortcomings in nxstyle, whether we fix them or not. In order to implement this particular feature, some minimal syntax parsing would be required; I am not sure we want to go that route. But we definitely need an issue in place to remind us that not all coding standard issues are addresses.
There are many, many things that are not checked by nxstyle. Some that come to mind:
Non-local scope (global) varialbes must begin with g_
Structure names must end with _s, union names must end with _u, enumeration names must end with _e, typedef'e names must end with _t
All identifiers are local case except the pre-processor names are all upper case.
etc.
There are more coding standard issues that are NOT addressed than there are coding standard issues addresses. I am not familiar with any automated pretty printer than can fix such things either.
from incubator-nuttx.
@johannes-nivus It is important that we document shortcomings in nxstyle, whether we fix them or not. In order to implement this particular feature, some minimal syntax parsing would be required; I am not sure we want to go that route. But we definitely need an issue in place to remind us that not all coding standard issues are addresses.
There are many, many things that are not checked by nxstyle. Some that come to mind:
Non-local scope (global) varialbes must begin with g_
How about stdin/stdout/stderr? any naming rule will have exception, but the standard has the high priority than coding style.
Structure names must end with _s, union names must end with _u, enumeration names must end with _e, typedef'e names must end with _t
But we need smart here: any struct/union/enum/typedef defined by the standard need to keep as before.
All identifiers are local case except the pre-processor names are all upper case.
etc.There are more coding standard issues that are NOT addressed than there are coding standard issues addresses. I am not familiar with any automated pretty printer than can fix such things either.
from incubator-nuttx.
Related Issues (20)
- iob_free: io_offset not taken into consideration when adjusting remaining io_pktlen? HOT 6
- Documentation: migrate pages from wiki
- Buggy handling of unsigned long in vsprintf_internal HOT 1
- Why kasan.c cannot use to stack overflow check ? the algorithm limit it ? HOT 1
- Failure in compilation of sim_hostusrsock.c due to improper handling of header inclusion for fd_set HOT 2
- Failed to build simulator HOT 2
- Unexpected behaviour with poll and tickless scheduler HOT 6
- gdb nsh:tcpblaster cannot access network HOT 7
- stringstream linker problem when Normal, Full Optimization Activated HOT 4
- Feature Request: Make C-header files compatible with C++ HOT 3
- Fail to nxtask_delete by update of cancel point logic HOT 9
- Math library header files are not exported HOT 2
- How to expand the size of a heap? HOT 1
- Gh HOT 1
- [bug] cmake building failed HOT 2
- SPI/DMA issue with ws2812 driver HOT 4
- WIFI thread crash in OTA mode HOT 4
- [question] Since nuttx and uboot have the same .config configuration and macros, do they also overlap in functionality? HOT 3
- Networking 1s Send Delay and SO_SNDTIMEO odd behavior HOT 7
- IEEE802.15.4 support for nRF52 and nRF53
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from incubator-nuttx.