Comments (16)
I am not the expert here. But I don't think that anything can come into the repositories that does not have an Apache 2.0 licence. That is the rule that we have been enforcing.
If it is not Apache code, then it is third party code and I think we would need an SGA or some such thing. Again, i am not the expert. You should ask Justin, not me.
I would not personally merge any files that have BSD licenses or any Copyrights on them.
from incubator-nuttx.
I think that all of the answers are here: https://www.apache.org/legal/resolved.html
from incubator-nuttx.
All most code under armv7-m come from you. It isn't a big issue If you give us the permission to modify the license.
from incubator-nuttx.
Yes, you have my permission to modify the licenses to Apache 2.0 provided that I am the sole copyright holder and the sole author. Other cases are more complex.
Perhaps we should resolve all license headers in armv7-m first?
from incubator-nuttx.
Other than me and Pinecone as claimed copyright holders, these files look problematic: dwt.h, etm.h, fpb.h, itm.h, itm_syslog.h, tpi.h, up_cache.c, up_itm.c, up_itm_syslog.c, up_stackcheck.c, and up_vectors.S
We need advice from a mentor.
from incubator-nuttx.
Yes, you have my permission to modify the licenses to Apache 2.0 provided that I am the sole copyright holder and the sole author. Other cases are more complex.
Perhaps we should resolve all license headers in armv7-m first?
Good ideal, we can resolve as much as possible first.
Other than me and Pinecone as claimed copyright holders, these files look problematic: dwt.h, etm.h, fpb.h, itm.h, itm_syslog.h, tpi.h, up_cache.c, up_itm.c, up_itm_syslog.c, up_stackcheck.c, and up_vectors.S
Pinecone is fully controlled by Xiaomi, so I think it isn't a big issue. How to handle the rest file, keep the copright as armv7-m?
We need advice from a mentor.
from incubator-nuttx.
from incubator-nuttx.
Yes, that is why is better that @patacongo clean up armv7-m arch manually and then armv8-m just need follow the result. I think no other people better than him to decide the right copyright license.
from incubator-nuttx.
Yes, that is why is better that @patacongo clean up armv7-m arch manually and then armv8-m just need follow the result. I think no other people better than him to decide the right copyright license.
@xiaoxiang781216 Done. Please review and merge PR #848
from incubator-nuttx.
@xiaoxiang781216 There are a few Pinecone files that I could not change. You wrote those files. When you create new versions for armv8-m, you should be able to use the Apache 2.0 on the new files.
from incubator-nuttx.
Do we have a SGA for Pinecone. I think Justin has warned us about this before, that in this case we need the company approval to change the licensing of the file not just the author.
I'm all for getting this done I just don't want to have questions later about if the conversion was done correctly.
from incubator-nuttx.
Do we have a SGA for Pinecone. I think Justin has warned us about this before, that in this case we need the company approval to change the licensing of the file not just the author.
The is a different issue. We did not change any Pinecone headers and do not plan to.
That is for the ARMv7-M architecture. Xiang is implementing the ARMv8-M architecture which will have all new files. If Xiang wrote those files and put the Pinecone license on them. If Xiang generates new files they will have Apache licensing.
So this is a grey area. But rest assured, not existing Pinecone file will have its header changed.
from incubator-nuttx.
I am the only party who has submitted the SGA so only my files can have the header changed.
But new files should all be apache 2.0 unless there is some other reason that requires a different license.
from incubator-nuttx.
Awesome! This all sounds good to me, just wanted to make sure we are on the same page to save trouble down the road.
from incubator-nuttx.
There are a handful of other problem files. I left them as they are for ARMv7-M. The question is, "What do we do for those when we leverage them to ARMv8-M?" There are three ARM header files, one PX4 file, and three or four more with either other people's persoanan name in the Copyright. Or they made trivial changes to my file and then decided they deserve a Copyright too. I always thought that was bad taste but that is the way it is.
from incubator-nuttx.
Ok, we will refine our patch basse on @patacongo copyright change, thanks.
from incubator-nuttx.
Related Issues (20)
- iob_free: io_offset not taken into consideration when adjusting remaining io_pktlen? HOT 6
- Documentation: migrate pages from wiki
- Buggy handling of unsigned long in vsprintf_internal HOT 1
- Why kasan.c cannot use to stack overflow check ? the algorithm limit it ? HOT 1
- Failure in compilation of sim_hostusrsock.c due to improper handling of header inclusion for fd_set HOT 2
- Failed to build simulator HOT 2
- Unexpected behaviour with poll and tickless scheduler HOT 6
- gdb nsh:tcpblaster cannot access network HOT 7
- stringstream linker problem when Normal, Full Optimization Activated HOT 4
- Feature Request: Make C-header files compatible with C++ HOT 3
- Fail to nxtask_delete by update of cancel point logic HOT 9
- Math library header files are not exported HOT 2
- How to expand the size of a heap? HOT 1
- Gh HOT 1
- [bug] cmake building failed HOT 2
- SPI/DMA issue with ws2812 driver HOT 4
- WIFI thread crash in OTA mode HOT 4
- [question] Since nuttx and uboot have the same .config configuration and macros, do they also overlap in functionality? HOT 3
- Networking 1s Send Delay and SO_SNDTIMEO odd behavior HOT 7
- IEEE802.15.4 support for nRF52 and nRF53
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from incubator-nuttx.