Support Spring boot 1.5.18 ?

[apache]

Support Spring boot 1.5.18 ?

[walking98]

It should be supported, please modify the version to 1.5.18 and try it. @xiaolongyuan

[xiaolongyuan]

Not supported.

ListenerContainerConfiguration.java

private void registerContainer(String beanName, Object bean) {
        Class<?> clazz = AopUtils.getTargetClass(bean);
        if (!RocketMQListener.class.isAssignableFrom(bean.getClass())) {
            throw new IllegalStateException(clazz + " is not instance of " + RocketMQListener.class.getName());
        } else {
            RocketMQMessageListener annotation = (RocketMQMessageListener)clazz.getAnnotation(RocketMQMessageListener.class);
            this.validate(annotation);
            String containerBeanName = String.format("%s_%s", DefaultRocketMQListenerContainer.class.getName(), this.counter.incrementAndGet());
            GenericApplicationContext genericApplicationContext = (GenericApplicationContext)this.applicationContext;
            genericApplicationContext.registerBean(containerBeanName, DefaultRocketMQListenerContainer.class, () -> {
                return this.createRocketMQListenerContainer(bean, annotation);
            }, new BeanDefinitionCustomizer[0]);
            DefaultRocketMQListenerContainer container = (DefaultRocketMQListenerContainer)genericApplicationContext.getBean(containerBeanName, DefaultRocketMQListenerContainer.class);
            if (!container.isRunning()) {
                try {
                    container.start();
                } catch (Exception var9) {
                    log.error("Started container failed. {}", container, var9);
                    throw new RuntimeException(var9);
                }
            }

            log.info("Register the listener to container, listenerBeanName:{}, containerBeanName:{}", beanName, containerBeanName);
        }
    }

genericApplicationContext.registerBean is Spring 5.x

[xiaolongyuan]

@walking98

[xiaolongyuan]

[walking98]

It can work in my test after change to<spring.boot.version>1.5.18.RELEASE</spring.boot.version> rocketmq-spring-boot-parent/pom.xml

1. changed the spring.boot.version to 1.5.18.RELEASE
2. cd rocketmq-spring/
3. mvn clean install -Dmaven.test.skip
4. run the samples and verify:
   cd rocketmq-spring-samples
   mvn clean package

@xiaolongyuan

[xiaolongyuan]

spring boot 1.5.x依赖为 4.3.x

[xiaolongyuan]

@walking98

[walking98]

The official release version supports Spring boot 2.x + Spring 5.X, the latest spring version.

The issue title should be "support Spring 4.x + Spring 1.X", this is a back-forward compatible issue. we need some investigation and figure out how to support both.

[walking98]

Here is a potential fix: #25

But it might not be checked in due to the official release will support Spring-boot 2.X only.

@xiaolongyuan

[xiaolongyuan]

@walking98 Why support Spring-boot 2.X only ?

[237chenhao]

@xiaolongyuan
1.

2.

3.

我本地运行demo是OK没有发现明显报错.

[walkerzhao]

@xiaolongyuan
1.

2.

3.

我本地运行demo是OK没有发现明显报错.

我用你这个改动，mvn clean package 编译就有报错.

我也觉得@walking98 应该支持低版本的spring boot 哇

不然很多使用低版本的springboot的服务，都得为了引入你这个jar包，然后去升级版本，升级版本可能会带来更多不可预料的问题

[xiaolongyuan]

@zhao41654828 我现在用的是 pull里面的那个方案 后面准备全面升级至spring boot 2了

[walking98]

Hope this discussion will help you understand why we no longer support spring boot 1.x
#25

[walkerzhao]

@zhao41654828 我现在用的是 pull里面的那个方案 后面准备全面升级至spring boot 2了

嗯，我也尝试切spring boot 2 吧